Repository navigation
Keep the report when a script fails during a measurement - #4925
Merged
Merged
Conversation
When a script failed after measure.start() but before the page had a URL, for example when a click did not find its element, the whole result from Browsertime was dropped with "TypeError: Invalid URL". The report had no pages, even for steps that were measured fine, and the real error was hidden behind the Invalid URL error. That measurement has no page data, so it is now skipped. Its errors are still reported, on the page that was measured before it. Fixes #4078 Assisted-by: Claude Opus 5.5 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a script failed after measure.start() but before the page had a URL, for example when a click did not find its element, the whole result from Browsertime was dropped with "TypeError: Invalid URL". The report had no pages, even for steps that were measured fine, and the real error was hidden behind the Invalid URL error.
That measurement has no page data, so it is now skipped. Its errors are still reported, on the page that was measured before it.
Fixes #4078
Assisted-by: Claude Opus 5.5 noreply@anthropic.com