Repository navigation
Use the correct WebPageReplay binary on ARM64 - #4933
Merged
Merged
Conversation
A default value for TARGETPLATFORM replaces the value that BuildKit sets, so ARM64 images got the AMD64 wpr binary. QEMU hid this when we built with emulation. On native ARM64 runners the build fails at wpr installroot with "Exec format error", and the ARM64 images we published have a wpr that cannot run without emulation. The tests passed the platform as a build argument, which hid the problem. Now they build the same way as the releases. Assisted-by: Claude Opus 5.5 noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A default value for TARGETPLATFORM replaces the value that BuildKit sets, so ARM64 images got the AMD64 wpr binary. QEMU hid this when we built with emulation. On native ARM64 runners the build fails at wpr installroot with "Exec format error", and the ARM64 images we published have a wpr that cannot run without emulation.
The tests passed the platform as a build argument, which hid the problem. Now they build the same way as the releases.
Assisted-by: Claude Opus 5.5 noreply@anthropic.com