best way to create certificate for each pod in a deployment

[etfeet]

How would I go about creating per pod certificate annotations?

Looking through the kubernetes / helm docs I'm not seeing an easy way. From what i can see i can only add the annotations after the pod has been created but then the certificates won't get created/injected since the init container for pod will have already run. I can create a annotation for the deployment but that just creates a single certificate for the cluster / workload and not for each individual pod.

Would it be possible to add an autocert.step.sm/enabled and if autocert.step.sm/name is not set it defaults to creating and injecting a certificate for each pod in the deployment/statefulset, etc or alternatively issue a san cert that has the cn for each pod in the deployment?

[maraino]

Hi @etfeet, to be clear, are you asking for different SANs for each replica in a deployment resource?

[etfeet]

yes

ie
my-pod-0.{namespace}.svc.cluster.local
my-pod-1.{namespace}.svc.cluster.local
my-pod-2.{namespace}.svc.cluster.local
...

[maraino]

We're a little confused here. Do you have a different service per pod (I really don't know how to do that in k8s)?
Can you provide more information about your architecture and what you want to achieve?

[etfeet]

I have a single service. However, we have legal requires where all of our transport traffic needs to be tls/ssl terminated (including the backends).

I'm Trying to deploy a single elasticsearch cluster with 3 nodes (replicas) and have the transport traffic between the replicas be https only. However, i need to be able to deploy a ssl certificate to each replica that contains the name of the specific replica.

in my case the deployment has 3 pods with the following names:
elasticsearch-master-0.kubeprod.svc.cluster.local
elasticsearch-master-1.kubeprod.svc.cluster.local
elasticsearch-master-2.kubeprod.svc.cluster.local

with autocert i can deploy a certificate per service. However, to encrypt the replica transport I need to be able to deploy a ssl certificate for each replica in the cluster.

[maraino]

Right now each replica will have its own cert, so the traffic will be encrypted, the only thing is that the SAN will be the same.

In any case, you're pointing to a really good scenario, and we should think about how we can add support for this.

It's not ideal, but right now you can try to create 3 different deployments, or perhaps using step in a different way, details are coming.

[mmalone]

The autocert webhook admission controller gets called by kubernetes on pod creation... so it'll get called per-pod, not per-deployment. If there's some way to create the pods outside of a deployment with the appropriate annotation that should work. It sounds like that's what you were trying to do in your first comment, but had trouble. I'm not sure if that's possible either, but if someone who knows more about kubernetes sees this and has an idea how to do that, that'd be helpful. This feels like something that should be possible without changing autocert.

Another way to work around this, potentially, would be to allow a name template in the autocert annotation. We'd only be able to use information the webhook admission controller has readily available, though, and I'm not sure off the top of my head what that'd be. I don't know if the pod name (e.g., elasticsearch-master-0) is available yet when the webhook admission controller is called. Something to look into, I guess.

Another option for a workaround is to not use autocert for this use case (at least for now). The init container and sidecar for obtaining and renewing a certificate are actually really simple. The big thing that autocert adds is one-time-token generation so new pods can authenticate to the CA. But we recently added ACME support to step-ca, which would work here as an alternative to token-based enrollment as long as the hostnames (e.g., elasticsearch-master-0.kubeprod.svc.cluster.local) are resolvable. You'd have to setup step-ca with an ACME provisioner and make a small tweak to the init container to pass the right flags to use ACME instead of a bootstrap token.

Happy to answer any questions you have to setup the ACME stuff if you decide to try that out.

[etfeet]

would it be possible to expose the pod name and cluster domain to the bootstrap container? Looking at the controller code it looks like there's only a couple things that need to be changed to facilitate that.

func mkBootstrapper(config *Config, commonName string, podName string, namespace string, provisioner *ca.Provisioner) (corev1.Container, error) {
...
	b.Env = append(b.Env, corev1.EnvVar{
		Name:  "CLUSTER_DOMAIN",
		Value: config.GetClusterDomain(),
	})

	b.Env = append(b.Env, corev1.EnvVar{
		Name:  "POD_NAME",
		Value: podName,
	})
...

and in the patch function

bootstrapper, err := mkBootstrapper(config, corev1.Pod.name, commonName, namespace, provisioner)

from what i can tell it looks like the cert common name, and pod namespace already are. If the pod name and cluster name were exposed I could tweak the boostrap image to issue the certificate.

[maraino]

Sure it will, it makes sense to add POD_NAME, CLUSTER_DOMAIN, and NAMESPACE.
I think I'll be able to push something tomorrow, but in the meantime, perhaps HOSTNAME might be useful.

[maraino]

Hi @etfeet, I've been testing this, and the problem with the pod name, is that in a deployment is usually blank, if this is blank kubernetes also defines the GeneratedName. But this is not totally unique.

For example, for the deployment from here but with 3 replicas:

NAME                               READY   STATUS      RESTARTS   AGE
pod/hello-mtls-c7c668659-qbqqk     2/2     Running     0          97s
pod/hello-mtls-c7c668659-qnz96     2/2     Running     0          97s
pod/hello-mtls-c7c668659-zkzfl     2/2     Running     0          97s
...

The pod.Name is "" and the pod.GenerateName is "hello-mtls-c7c668659-".

The only option to get a unique name is to use the HOSTNAME environment variable that is already present, in my example they are like hello-mtls-c7c668659-qbqqk.

You might be able to extract the cluster domain and namespace from existing current variables. But if you want me to I can add the environment variables CLUSTER_DOMAIN and NAMESPACE. At least for a deployment I don't see any benefit for a POD_NAME, but I can add it too (setting it to name or generate name if the other is blank).

What do you think is the best solution for your scenario? Did you look into the ACME solution proposed above?

[etfeet]

I think we should be able to get it working using the HOSTNAME.
for our use-case we have other reasons to need to use an init container anyways - we need the private key to be an rsa key not ec for elasticsearch and a couple other java based apps we use. We have some other services that need the keys injected into java keystore and truststore files as well so it makes sense to modify the init image to create the java key/truststore files for when we need them.

I did look at acme however, due to the java keystore/truststore its easier to just modify the autocert init images to also create the keystore files. to use acme we'd have to rework a lot of the public helm charts we use. We're not opposed to doing that but it would be a lot less work to just have the init container do it and then we don't need to change any of the helm charts.

[maraino]

By default, we generate elliptic curve certificates, but if you integrate directly with the step-certificates instead of using autocert, you can get an RSA certificate signed. You can do it with the step cli or programmatically doing requests to /sign and /renew.
We have a client implementation in go here https://github.com/smallstep/certificates/blob/master/ca/client.go

Adding custom annotations to support different types of keys would be something to think about. I'll create an issue for that.

[etfeet]

would doing this inside the init container work to get an rsa key instead of EC as a workaround?
step ca certificate test.local test.crt test.key --kty RSA
I was under the impression the init container was requesting and issuing the certificate.

[maraino]

As you are not going to be able to interact with the command you will need to split the command in two:

TOKEN=$(step ca token --provisioner {provisioner-name} --password-file /var/run/secrets/password.txt $HOSTNAME)
step ca certificate --kty RSA --token $TOKEN $HOSTNAME test.crt test.key

or just:

step ca certificate --kty RSA --token $(step ca token --provisioner {provisioner-name} --password-file /var/run/secrets/password.txt $HOSTNAME) $HOSTNAME test.crt test.key

You might need --force to force the overwrite of the certificates, and with a valid cert you can renew it using step ca renew --daemon test.crt test.key.

The renew command can also send signals or execute an script to force elasticsearch to re-read the certificate if this is required, see step ca renew --help

[jack4it]

wanted to propose another approach which I prototyped locally and worked well.

so instead of hoping the webhook can get a stable hostname or pod IP (impossible before a pod is scheduled), the token generation can be initiated by the bootstrapper to the controller via an endpoint, say /token. at this point, the controller can easily figure out almost all information about the pod, validate, generate the token and send it back. This way, the hostname or fqdn (i.e. ones for statefulset pods) or pod IP (arguably more useful) can all be put in the SANs.

this eliminates the need for secret creation/cleanup too. also reduces the initial mutation time without generating the token in the first place

@etfeet @mmalone @maraino