Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review after #69
Fixes finding
0b438802-f8e4-4941-abdb-8b9ce36f2127: a single unreachable recorded verifier disables the entire drift monitor and is reported asrpc-unavailable.Issue
If any recorded verifier, resolver or factory had no code on the chain, DriftCheck reverted before comparing anything, and without the
DRIFT_DETECTEDmarker.drift-check.shthen exited 2 (rpc-unavailable), so one stale record inconfig/deployments/<alias>.jsonswitched off drift monitoring for the whole chain and looked like a network problem.What changed
_assertReachableis replaced bycheckReachability. Each recorded contract with no code is reported asDRIFT_DETECTED … has NO CODE at its recorded addressand counted as drift (exit 1).--rpc-urlstill exits 2:run()checks the chainid against the chain config before reading anything, so acodeless address after that point is a bad record.