feat: head reporter metrics via beholder metrics (#23250) - #23557
feat: head reporter metrics via beholder metrics (#23250)#23557bukata-sa wants to merge 3 commits into
Conversation
f409157 to
fd867dd
Compare
|
I see you updated files related to
|
|
✅ No conflicts with other open PRs targeting |
|
|
26080bf to
f9df8b8
Compare
f9df8b8 to
be3db5c
Compare
be3db5c to
a15ebd2
Compare
|
| return &evmMetricsReporter{lggr: lggr, metrics: metrics, selectors: selectors} | ||
| } | ||
|
|
||
| func (r *evmMetricsReporter) ReportNewHead(ctx context.Context, head *evmtypes.Head) error { |
There was a problem hiding this comment.
I wonder if we need a dedicated evmMetricsReporter.
HeadTracker doesn't guarantee that for every head, we'll have a LatestFinalizedHead.
We send a notification of a new head right away; the backfill operation (building the chain from the latest to the finalized block) runs asynchronously. The backfill uses cached chain, but if there is a gap, it may take significant time to fully reconstruct it. So in corner cases, LatestFinalizedHead() may be nil.
Since both prom and beholder metrics are captured once every ~15s, the benefit of updating the metric on every block is minimal.
There was a problem hiding this comment.
Ah, that's a cherry-pick. never mind
4 participants
Cherry-picked from 1543766
feat: head reporter metrics via beholder metrics
lint
bump down timeout to 2s