Repository navigation
Feature: allow configuring debug button position - #1009
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The source map is stale and the resize-reset behavior lacks regression coverage.
1 open finding
What changed in this PR
Adds CSS customization for the debug button’s position through a shadow part.
Changes:
- Exposes the debug button as
::part(debug-button). - Adds a stable shadow-host ID and viewport-reset behavior.
- Documents and tests custom positioning.
| File | Description |
|---|---|
assets/client/client.js |
Identifies the shadow host. |
assets/client/components/debug_button/debug_button.html |
Exposes the button part. |
assets/client/components/debug_button/debug_button.js |
Restores CSS positioning after invalid drag offsets. |
docs/config.md |
Documents position customization. |
e2e/tests/debug-button-part.spec.ts |
Tests shadow-part styling. |
priv/static/client.js |
Updates the generated client bundle. |
priv/static/client.js.map |
Updates generated source mappings. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kraleppa
approved these changes
Oct 9, 2026
srzeszut
added a commit
that referenced
this pull request
Oct 9, 2026
* allow configure debug button position * add doc * add test * update mix.lock * format * add precommit * fix precommit * fix 1.16 formating * format * remove format from workflow * simplify and remove unecessary changes * cr suggerstions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.