A11y fix from agent in main by ludmilaFialova · Pull Request #857 · solarwinds/nova

ludmilaFialova · 2026-05-26T05:56:50Z

Frontend Pull Request Description

https://swicloud.atlassian.net/browse/OO-62923
Using an agent to fix all accessibility issues in the Nova repository.
Plus, added some Percy test fixes.

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my code
I have updated change log
I have been following Definition of done
I have commented my code, particularly in hard-to-understand areas
My changes generate no new lint warnings
New and existing unit tests pass locally and on CI with my changes
Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Additional Context (if necessary)

pavlo-poimanov · 2026-05-27T13:56:45Z


        &-remove {
            cursor: pointer;
+            display: inline-flex;


no regression? or it is bug fix?

This was to fix the position of the icon after inserting it into <span> in chip.component.html

pavlo-poimanov

I like it

(Tab → Enter/Space) and will display a visible focus indicator

The host element declared role=progressbar with the same aria-value* and label attributes already present on .nui-progress__container, producing nested progressbar nodes. Because progressbar has children-presentational semantics, the host-level role also removed the cancel button, message and hint from the accessibility tree. Also drop the duplicated [id]=helpId from the default help template; the id stays on the .nui-progress__hint wrapper, which is always rendered and is the correct aria-describedby target for both default and custom help templates.

The body wrapper was always a region landmark labelled by the header. On the demo page alone that produced 10 landmarks, 7 of which shared a name with another, including a region nested inside a region. W3C APG lists the role as optional and warns against landmark proliferation, but a standalone expander cannot know how many siblings a page has. The new useRegionLandmark input keeps the capability for pages with few panels while defaulting to off. aria-controls and aria-expanded still tie the header to the body.

…n_main

removeItem clicked the n-th remove icon and returned immediately, so a following index-based call could target the stale list. The Chips visual test (removeItem(2) then removeItem(3)) therefore nondeterministically removed Unknown instead of Ok, causing a Percy diff against main. removeItem now waits until the chip count drops by one.

CI runs UI tests without PERCY_TOKEN, so snapshots are plain Playwright screenshots taken by EyesLens and uploaded with percy upload; Percy does not re-render the page. Camera.cheese() now forces all declared web fonts to load, awaits document.fonts.ready and two animation frames before each snapshot, preventing invisible or shifted text and misplaced overlays/tooltips. EyesLens takes screenshots with animations: disabled and caret: hide, so infinite CSS animations (nui-spinner, indeterminate nui-progress) are captured in a stable state. Because snapshots no longer capture animations, new e2e checks verify that nui-spinner runs the rotate and dash animations and the indeterminate nui-progress bar runs indeterminate-progress. Documented the CI snapshot flow in docs/E2E/VISUAL.md and corrected outdated notes (lens selection, disableCSSAnimations limitation).

Fix new lint warnings (import order in selector, inject() in OverlayComponent, standalone test host in tab-group spec), type dialog Tab handlers as KeyboardEvent, remove unused imports and a fixed timeout from the dialog focus-trap e2e test, and restore the playwright-test-healer agent frontmatter from main. Add unit tests for overlay focus trapping and focus restore, textbox-number ARIA semantics and KPI tile keyboard activation. Add demo examples documenting the new overlay (trapFocus, ARIA inputs) and dialog (ariaLabel, ariaLabelledby, ariaDescribedby) options and summarize the accessibility changes in CHANGELOG

ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch 3 times, most recently from 577a1b2 to 9e22c8e Compare May 27, 2026 10:20

pavlo-poimanov reviewed May 27, 2026

View reviewed changes

pavlo-poimanov previously approved these changes May 27, 2026

View reviewed changes

ludmilaFialova dismissed pavlo-poimanov’s stale review via 689d3b8 May 28, 2026 18:34

ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch 4 times, most recently from 8cde0eb to 276bdad Compare May 29, 2026 07:08

ludmilaFialova marked this pull request as draft June 4, 2026 17:21

ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch 10 times, most recently from 6138d55 to 90d1f7e Compare June 12, 2026 12:46

ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch from 90d1f7e to 7a61333 Compare June 15, 2026 09:51

ludmilaFialova marked this pull request as ready for review June 15, 2026 09:55

ludmilaFialova requested a review from pavlo-poimanov June 15, 2026 09:55

ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch from 7a61333 to 35ca2bb Compare June 15, 2026 11:36

ludmilaFialova requested a review from erzik987 June 19, 2026 10:05

pavlo-poimanov previously approved these changes Jul 22, 2026

View reviewed changes

ludmilaFialova dismissed pavlo-poimanov’s stale review via c70b4d6 August 11, 2026 08:39

ludmilaFialova added 2 commits September 21, 2026 20:34

OO-62923 CRITICAL bits a11y issues

15d5e0b

OO-62923 l18n and IMPORTANT bits a11y issues

5c47cd8

ludmilaFialova added 17 commits September 21, 2026 21:34

OO-62923 IMPORTANT a11y fixed round 2

7471efe

OO-62923 The tabs in nui-tab-group are now fully keyboard-accessible

481c196

(Tab → Enter/Space) and will display a visible focus indicator

OO-62923 button click animation same for mouse and keyboard

558a3f1

OO-62923 A11y unit tests

e014fab

OO-62923 table widget and component

3438ec5

OO-62923 charts, dashboards and readme fix

c9ef187

OO-62923 a11y fix of bits round 3

d412c1f

OO-62923 fix of e2e tests

9c8189a

NUI-6103 .focus-outline()

2053591

OO-62923 a11y fix of bits round 4

9b6b563

OO-62923 Custom ID for translation of Angular i18n

2277321

OO-62923 e2e tests fix

fd5edfc

OO-62923 dialog in overlay a11y fix

caa51b3

OO-62923 agent

3658e1b

OO-62923 a11y fix of bits round 5

b5adde6

bits-verify fixed

50de989

OO-62923 SkipSpace issue fixed

bb3f43c

ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch from c70b4d6 to bb3f43c Compare September 21, 2026 20:55

bits-ui-tests errors fixed

af02690

ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch from 7f77aa1 to af02690 Compare September 22, 2026 16:57

ludmilaFialova added 2 commits September 22, 2026 19:03

ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch from cc5c37e to 6b56b1d Compare September 29, 2026 14:24

Merge remote-tracking branch 'origin/main' into A11y_fix_from_agent_i…

07592bf

…n_main

ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch from 6b56b1d to 07592bf Compare September 29, 2026 15:12

ludmilaFialova added 2 commits September 30, 2026 10:01

ludmilaFialova force-pushed the A11y_fix_from_agent_in_main branch from f1595bc to c115319 Compare September 30, 2026 11:15

ludmilaFialova requested a review from pavlo-poimanov September 30, 2026 14:38

Navigation Menu

A11y fix from agent in main - #857

A11y fix from agent in main#857
ludmilaFialova wants to merge 31 commits into
mainfrom
A11y_fix_from_agent_in_main

ludmilaFialova commented May 26, 2026 •

edited

Loading

Uh oh!

pavlo-poimanov May 27, 2026

Uh oh!

ludmilaFialova May 27, 2026 •

edited

Loading

Uh oh!

pavlo-poimanov left a comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

Conversation

ludmilaFialova commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Frontend Pull Request Description

Checklist

Screenshots (if applicable)

Additional Context (if necessary)

Uh oh!

pavlo-poimanov May 27, 2026

Choose a reason for hiding this comment

Uh oh!

ludmilaFialova May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pavlo-poimanov left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants

ludmilaFialova commented May 26, 2026 •

edited

Loading

ludmilaFialova May 27, 2026 •

edited

Loading