Bugfix - NUI-6283: [a11y] role="tab" elements do not have aria-controls pointing to their panel, etc. (WCAG 4.1.2) - #897
Merged
ludmilaFialova merged 24 commits intoSep 22, 2026
Conversation
kubeska
marked this pull request as ready for review
August 12, 2026 16:21
ludmilaFialova
previously approved these changes
Aug 19, 2026
ludmilaFialova
force-pushed
the
bugfix/NUI-6283-a11y-incorrect-aria-controls-on-tab-elements
branch
from
September 1, 2026 21:21
19243df to
14b5b21
Compare
ludmilaFialova
previously approved these changes
Sep 4, 2026
ludmilaFialova
force-pushed
the
bugfix/NUI-6283-a11y-incorrect-aria-controls-on-tab-elements
branch
from
September 7, 2026 15:21
ffd3916 to
8c7ef4c
Compare
ludmilaFialova
force-pushed
the
bugfix/NUI-6283-a11y-incorrect-aria-controls-on-tab-elements
branch
from
September 17, 2026 17:34
8c7ef4c to
102f369
Compare
| autocrlf=false | ||
| eol=lf | ||
| * text=auto | ||
| * text=auto eol=lf |
Contributor
There was a problem hiding this comment.
The .gitattributes file was updated to enforce consistent LF line endings across the repository.
This prevents Windows-specific CRLF conversions from causing unnecessary diffs and Prettier or CI failures. It ensures that all developers and CI use the same line-ending format.
pavlo-poimanov
previously approved these changes
Sep 21, 2026
- Implement roving tabindex so only active tab is in tab sequence - Add ArrowLeft / ArrowRight / ArrowUp / ArrowDown navigation - Add Home / End keys support to jump to first / last enabled tab - Add aria-orientation attribute to vertical tablists - Expose aria-disabled on disabled tabs - Add unit and e2e test coverage for keyboard interactions
- Make active tabpanels focusable with tabindex=0 - Keep inactive tabpanels out of the tab sequence - Cover Tab navigation into tabpanels - Test arrow wrap-around and disabled tab handling - Add vertical ArrowUp and ArrowDown coverage
- Add ariaLabel input to TabHeadingComponent and bind to role=tab - Provide accessible name for Settings tab in router demo - Add aria-controls to all tabs referencing shared routed panel - Update unit tests and Playwright test suite
Add accessible names to icon-only tabs, fix prefixed active-tab bindings, and scope force-click behavior to the disabled-tab test.
Handle Enter activation for switch controls and add unit and e2e regression coverage.
Keep public ids on nui-switch hosts, provide fallback labels for unlabeled switches, and add accessible names to chart demo switches.
Restore keyboard activation for routed tabs, add edge-case coverage for disabled tabs and generated IDs, and strengthen switch and tab accessibility assertions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ludmilaFialova
force-pushed
the
bugfix/NUI-6283-a11y-incorrect-aria-controls-on-tab-elements
branch
from
September 21, 2026 12:18
102f369 to
de948e1
Compare
pavlo-poimanov
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend Pull Request Description
This PR improves the accessibility of the tab and tab-panel relationship across the
@nova-ui/bitslibrary. The main change is to ensure that tab and panel elements have properly aligned IDs and ARIA attributes. This includes updates to both the implementation and the demos, as well as the addition of tests to verify the correct associations.Accessibility Improvement:
tab-{id}for tabs andpanel-{id}for panels), and the ARIA attributesaria-controlsandaria-labelledbyare set accordingly in bothTabComponentandTabHeadingComponent. This ensures screen readers and assistive technologies can correctly associate tabs with their panels.Code:
tabgroup.constants.tsand used throughout the codebase for consistency.Documentation:
Checklist
Screenshots (if applicable)
Additional Context (if necessary)
The PR includes the following main changes:
Added correct ARIA relationships between tabs and panels:
role="tab",role="tablist", androle="tabpanelaria-controlson tabsaria-labelledbyon panelstab-*andpanel-*ID generationExtended
Tab,TabHeading,TabGroup, andTabHeadingGroup:tabIdsupportariaControlssupportariaLabelsupport for tabs without a text labelaria-selected,aria-disabled, andtabindexImplemented APG keyboard navigation:
HomeandEndfor moving to the first or last enabled tabEnterandSpacefor activationtabindexImproved focus and disabled-tab handling:
Improved
Switchaccessibility:idplacementariaLabelsupportSwitchEnterandSpacekeyboard activationUpdated demo examples:
Expanded test coverage:
Updated the changelog, package versions, and related repository formatting settings.