Skip to content

fix(compiler,babel-plugin): run later-declarator JSX setup after the declarators before it (#5102) - #5103

Merged
ryansolid merged 1 commit into
mainfrom
claude/project-thread-qcipzk-5102
Nov 20, 2026
Merged

ryansolid merged 1 commit into
mainfrom
claude/project-thread-qcipzk-5102

Conversation

@ryansolid

Copy link
Copy Markdown
Member

Requested by Ryan · project thread

Fixes #5102.

Summary

When JSX sat in a later declarator of one declaration (const label = …, onClick = …, view = <div onClick={onClick}/>), both compilers put the element's setup before the whole statement, so it read the earlier declarators before they were initialized. Minifiers make this shape (joinVars), so libraries that ship minified JSX crashed on load.

The fix uses the existing statement-position path and splits the declarators before the JSX into their own statement first. The setup then goes between them and the rest:

const label = mk(), onClick = () => label;
var _el$ = _tmpl$();
_el$.$$click = onClick;
_$setAttribute(_el$, "title", label);
const view = _el$, other = 1;
  • Babel: getSetupStatement (shared by DOM, universal and SSR) does the split. export const keeps the split part exported.
  • Native: the same split in lower_variable_jsx_initializer (DOM and universal) and in the SSR statement flush. It only splits when that JSX actually has setup, the same as Babel.
  • SSR was also affected, more narrowly than the issue says: an eager hoisted value such as a component call (_v$ = escape(Foo({ a: label }))) ran before label. That is fixed too.

No runtime code changed, so client bundle size is unchanged. RULES-FUNDAMENTALS and RULES-DERIVED don't apply here, because this is compiler statement order and not reactive semantics.

How did you test this change?

  • New packages/babel-plugin/test/declarator-order.spec.js runs the compiled output against a stub runtime in dom, dom hydratable, universal and ssr. All 8 tests fail on main and pass here. Babel suite: 440 passed, typecheck clean.
  • New parity probe in packages/compiler/__tests__/parity-probes.test.js: native output is identical to Babel in every mode (4125 passed). Compiler vitest: 6952 passed. cargo test passes for all three feature sets, and clippy -D warnings is clean.

Generated by Claude Code

…declarators before it (#5102)

A declaration whose later declarator holds JSX hoisted the element's
setup above the whole statement, so it read earlier declarators before
initialization (minifiers' joinVars makes this shape). Split the
declarators before the JSX into their own statement first, in the DOM,
universal and SSR outputs of both compilers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWPYxt1bEM9zZ5G6dPL
@changeset-bot

changeset-bot Bot commented Nov 20, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ae43313

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@solidjs/compiler Patch
@solidjs/babel-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryansolid ryansolid self-assigned this Nov 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Size (brotli, eager entry chunk)

scenario head vs base minified vs base minified vs recorded cap lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush) 7.50 KB 0 B 0 B −212 B 7.56 KB ✅
signals: + createStore 15.15 KB 0 B 0 B +12 B 15.13 KB ⚠️ over by 18 B, 8 B minified headroom
signals: + isPending/latest 13.41 KB 0 B 0 B 0 B 13.43 KB ✅
signals: + until/refresh (truth readers, no optimism) 8.21 KB 0 B 0 B −49 B 8.23 KB ✅
app: render + one signal (the simple-app floor) 9.75 KB 0 B 0 B −515 B 9.85 KB ✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy 19.04 KB 0 B 0 B −337 B 19.14 KB ✅ lazy-page.js 0.04 KB
app: hydrating + every store primitive family 35.43 KB 0 B 0 B +13 B 35.45 KB ✅ lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy 13.77 KB 0 B 0 B −297 B 13.86 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the observe artifacts) 15.47 KB 0 B 0 B −297 B 15.59 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled 30.06 KB 0 B 0 B −375 B 30.22 KB ✅ lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click) 9.93 KB 0 B 0 B −586 B 10.03 KB ✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store) 26.74 KB 0 B 0 B −238 B 26.75 KB ✅ stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable) 33.00 KB 0 B 0 B −189 B 33.00 KB ✅ stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec) 11.78 KB 0 B 0 B +5 B 11.80 KB ✅
page: base server components (hydrating + dynamic + frames + sf reference) 34.20 KB 0 B 0 B −170 B 34.21 KB ✅ assets.js 0.78 KB, decode.js 7.41 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.35 KB, wire.js 3.48 KB
page: live server components (base + live/GET + action + isPending/latest) 41.62 KB 0 B 0 B 0 B 41.63 KB ✅ assets.js 0.78 KB, decode.js 7.41 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.35 KB, wire.js 3.48 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread) 36.04 KB 0 B 0 B −220 B 36.06 KB ✅ assets.js 0.78 KB, decode.js 7.41 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 9.31 KB, wire.js 3.48 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest) 45.78 KB 0 B 0 B 0 B 45.80 KB ✅ eager (counted): web.js 24.24 KB; assets.js 0.78 KB, decode.js 7.41 KB, regions.js 1.08 KB, sc-comments.js 0.19 KB, trace.js 9.30 KB, wire.js 3.48 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate) 41.62 KB 0 B 0 B −175 B 41.75 KB ✅ assets.js 0.78 KB, decode.js 7.41 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, server.js 1.05 KB, serverForms.js 3.58 KB, trace.js 9.29 KB, wire.js 3.48 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate) 51.37 KB 0 B 0 B 0 B 51.41 KB ✅ eager (counted): client.js 29.41 KB; assets.js 0.78 KB, decode.js 7.41 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.05 KB, serverForms.js 3.30 KB, trace.js 9.31 KB, wire.js 3.50 KB
server: floor (getRequestEvent + isServer) 1.31 KB 0 B 0 B 0 B 1.33 KB ✅
server: renderToString (the server-render floor) 23.60 KB 0 B 0 B 0 B 23.62 KB ✅

⚠️ Over the brotli cap within the minified allowance (passes)

  • signals: + createStore: over brotli cap by 18 B; minified 43,976 B vs 43,964 B recorded with the cap (+12 B) — 8 B of the 20 B minified allowance left; +0 B minified over this PR's base

Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 44705089856

Coverage remained the same at 79.459%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1372
Covered Lines: 1152
Line Coverage: 83.97%
Relevant Branches: 1106
Covered Branches: 817
Branch Coverage: 73.87%
Branches in Coverage %: Yes
Coverage Strength: 29.91 hits per line

💛 - Coveralls

@codspeed

codspeed Bot commented Nov 20, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

2 warnings

⚠️ Upgrade your CodSpeed plugin for Node.js 24

@codspeed/* 5.4.0 is only tested on Node.js 18, 20, and 22, so your Node.js 24 measurements may be inaccurate. Upgrade your @codspeed/* packages to 6.0.0 or later.

See affected benchmarks

⚠️ 2 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 201 untouched benchmarks
⏩ 5 skipped benchmarks1


Comparing claude/project-thread-qcipzk-5102 (ae43313) with main (99db9bc)

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@ryansolid
ryansolid merged commit d364031 into main Nov 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2.0 compiler] JSX in a later declarator has its setup hoisted above the declaration, so it reads earlier declarators before initialization

3 participants