Repository navigation
fix(docker): inline base image digest so Renovate can update it - #532
Merged
Merged
Conversation
Renovate resolves FROM node:<tag>@sha256:${base_sha} via the ARG, but can't write a new digest back because the ARG holds only the hex part. Every update touching the Dockerfile node image failed with "Error updating branch: update failure", blocking the grouped non-major PR and the Node image PRs. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-c46f6134-ceb4-4cd6-ba8f-0f439d65ef5d
stefanhengl
approved these changes
Nov 5, 2026
chrapkowski-sg
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate's Dependency Dashboard (#5) reports `Error updating branch: update failure` for every update that touches the Dockerfile's `node` image (`renovate/node-24.22.1-slim`, `renovate/all-minor-patch`, `renovate/node-26.x`).
Renovate resolves `FROM node:@sha256:${base_sha}` through the ARG, but can't write the new digest back because the ARG holds only the hex part without the `sha256:` prefix. It rewrites the tag, sees the digest unchanged, and fails the whole branch. Nothing passes `--build-arg base_sha`, so this inlines the digest into `FROM` (same image) and makes the stale version/digest in the example comment generic.
Test plan