Skip to content

fix(docker): inline base image digest so Renovate can update it - #532

Merged
christoph-sg merged 1 commit into
mainfrom
fix-renovate-dockerfile-digest
Nov 5, 2026
Merged

christoph-sg merged 1 commit into
mainfrom
fix-renovate-dockerfile-digest

Conversation

@christoph-sg

Copy link
Copy Markdown
Contributor

Renovate's Dependency Dashboard (#5) reports `Error updating branch: update failure` for every update that touches the Dockerfile's `node` image (`renovate/node-24.22.1-slim`, `renovate/all-minor-patch`, `renovate/node-26.x`).

Renovate resolves `FROM node:@sha256:${base_sha}` through the ARG, but can't write the new digest back because the ARG holds only the hex part without the `sha256:` prefix. It rewrites the tag, sees the digest unchanged, and fails the whole branch. Nothing passes `--build-arg base_sha`, so this inlines the digest into `FROM` (same image) and makes the stale version/digest in the example comment generic.

Test plan

  • `renovate --platform=github --dry-run=full sourcegraph/scip-typescript` on `main` reproduces the three `update failure` errors, each with `Dockerfile | node | Digest is not updated` in the debug log.
  • The same dry run against this change: all three branches reach `DRY-RUN: Would commit files to branch …` with no warnings.
  • `yarn build`, `yarn test` (45/45), `yarn eslint`, `yarn prettier-check` pass.

Renovate resolves FROM node:<tag>@sha256:${base_sha} via the ARG, but
can't write a new digest back because the ARG holds only the hex part.
Every update touching the Dockerfile node image failed with
"Error updating branch: update failure", blocking the grouped non-major
PR and the Node image PRs.

Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-c46f6134-ceb4-4cd6-ba8f-0f439d65ef5d
@christoph-sg
christoph-sg merged commit a2be8f6 into main Nov 5, 2026
5 checks passed
@christoph-sg
christoph-sg deleted the fix-renovate-dockerfile-digest branch November 5, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants