Migrate legacy Jedis Cluster API to UnifiedJedis - #3424
Closed
viktoriya-kutsarova wants to merge 4 commits into
Closed
viktoriya-kutsarova wants to merge 4 commits into
viktoriya-kutsarova wants to merge 4 commits into
Conversation
Signed-off-by: viktoriya.kutsarova <viktoriya.kutsarova@redis.com>
Signed-off-by: viktoriya.kutsarova <viktoriya.kutsarova@redis.com>
…cks that expect UnifiedJedis. Signed-off-by: viktoriya.kutsarova <viktoriya.kutsarova@redis.com>
Signed-off-by: viktoriya.kutsarova <viktoriya.kutsarova@redis.com>
viktoriya-kutsarova
force-pushed
the
topic/unified-jedis-cluster
branch
from
September 1, 2026 17:25
fe7ab72 to
80d1cf1
Compare
Contributor
Author
|
I was thinking we might also want to add a few lines in the upgrade guide regarding the change for the callbacks. If someone extended any of the callbacks, they would need to update them to use UnifiedJedis. |
UnifiedJedis
mp911de
added a commit
that referenced
this pull request
Sep 15, 2026
Introduce JedisClusterCommandCallback and JedisInvoker methods to accept ProtocolCommand for executeCommand call wrapping. See #3424
Member
|
Thank you for your contribution. That's merged and polished now. I've updated the release notes accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3315, completing the
UnifiedJedismigration for the cluster path.The cluster command callbacks were still typed over
Jedis, and the node resource provider still handed outJedisinstances, which is not aUnifiedJedissubtype. This PR moves the remaining cluster internals toUnifiedJedisand removes the last uses of the deprecatedsendCommandAPI.Changes
JedisClusterCommandCallback/JedisMultiKeyClusterCommandCallbacknow extendClusterCommandCallback<UnifiedJedis, T>/MultiKeyClusterCommandCallback<UnifiedJedis, T>. Source-incompatible for subclasses that implemented callbacks againstJedis.JedisClusterNodeResourceProviderreturns aUnifiedJedisAdapterwrapping the nodeConnectioninstead ofJedis.UnifiedJedis(CLUSTER *,BGREWRITEAOF,BGSAVE,SAVE,LASTSAVE,CONFIG RESETSTAT/REWRITE,TIME,CLIENT LIST/KILL,SHUTDOWN) useexecuteCommand(new CommandArguments(...)); all remainingsendCommandcalls (deprecated since Jedis 7.4.0) are migrated as well.JedisConverters.migratenow appliesMigrateOption(COPY/REPLACE) viaMigrateParams.jsonMGetroutes through the typed multi-key callback using the per-node client.Testing
Existing integration suite passes against local cluster infrastructure; no new tests.