Skip to content

docs: clarify pull request validation #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gaalbu wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

docs: clarify pull request validation #429

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,18 @@ Once the fix is released, you will need to create a new, related ticket with a f

You can contribute a source code change by submitting a pull request.

Before opening the pull request, verify the patch locally:

```shell
./mvnw spring-javaformat:apply
./mvnw test
git diff --check
```

Keep the patch focused on the related ticket, and include the ticket number in the pull request
description. If you are working from a fork, push the branch to the fork and target
`spring-projects/spring-grpc:main` when creating the pull request.

1. You must have the right to submit code changes. Spring gRPC follows [Developer Certificate of Origin (DCO)](https://developercertificate.org/) rules. Commit messages must contain a `Signed-off-by` line. Git even has a `-s` command line option to append this automatically to your commit message:

```
Expand Down