Repository navigation
feat(delete): Nova, Keycloak and the Ingresses carry the PlatformInstance owner reference (#586 slice b) - #591
Merged
Merged
Conversation
…ance owner reference (D18, operator#588)
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice b of stardelt-operator#586 (D18, epic#55 definition of done 3). Slice a (#587) landed as
80a2909.The operator's bare workloads — the Nova ServiceAccount/Roles/RoleBindings/Service/Deployment, the Keycloak ConfigMaps/Service/Deployment and the Ingresses — carried no owner reference, so
kubectl delete platforminstanceleft them running. This stampsmetadata.ownerReferenceswith the PlatformInstance through a newobjects::platform_owner+objects::ownand aprovision::apply_ownedwrapper, so the garbage collector removes them with the instance.Never stamped (D18 retains them): Secrets, PVCs, the CNPG
Cluster/ScheduledBackup, the Strimzi Kafka CRs, the Trino config maps and the ServicePrincipals — theapplycall sites for those are untouched.The branch was pushed by the implementer session that died on an ECONNRESET after the push; opening the PR is the architect's, the code is unchanged from
aec9d99.Closes #588. Unblocks #589 and stardelt-platform#1043.