Skip to content

feat(delete): Nova, Keycloak and the Ingresses carry the PlatformInstance owner reference (#586 slice b) - #591

Merged
schwarztrinker merged 1 commit into
mainfrom
feat/588-own-workloads
Nov 12, 2026
Merged

schwarztrinker merged 1 commit into
mainfrom
feat/588-own-workloads

Conversation

@schwarztrinker

Copy link
Copy Markdown
Contributor

Slice b of stardelt-operator#586 (D18, epic#55 definition of done 3). Slice a (#587) landed as 80a2909.

The operator's bare workloads — the Nova ServiceAccount/Roles/RoleBindings/Service/Deployment, the Keycloak ConfigMaps/Service/Deployment and the Ingresses — carried no owner reference, so kubectl delete platforminstance left them running. This stamps metadata.ownerReferences with the PlatformInstance through a new objects::platform_owner + objects::own and a provision::apply_owned wrapper, so the garbage collector removes them with the instance.

Never stamped (D18 retains them): Secrets, PVCs, the CNPG Cluster/ScheduledBackup, the Strimzi Kafka CRs, the Trino config maps and the ServicePrincipals — the apply call sites for those are untouched.

$ cargo fmt --check && cargo clippy --all-targets -- -D warnings && cargo test
test result: ok. 630 passed; 0 failed

The branch was pushed by the implementer session that died on an ECONNRESET after the push; opening the PR is the architect's, the code is unchanged from aec9d99.

Closes #588. Unblocks #589 and stardelt-platform#1043.

Copilot AI lite review requested due to automatic review settings November 12, 2026 08:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@schwarztrinker
schwarztrinker merged commit 08d29fa into main Nov 12, 2026
2 checks passed
@schwarztrinker
schwarztrinker deleted the feat/588-own-workloads branch November 12, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(delete): Nova, Keycloak and the Ingresses carry the PlatformInstance owner reference (#586 slice b)

2 participants