[schwarztrinker]

Refs #589. Slice c of #586.

What changed

Seven functions in crates/stardelt-operator/src/provision.rs take owner: &OwnerReference and apply every object through apply_owned (which stamps the owner reference before the server-side apply):

function	objects
ensure_pg_dumps	one CronJob per database
ensure_superset_rbac	ServiceAccount, Role, RoleBinding
ensure_superset_group_roles	ConfigMap, CronJob
ensure_airflow_rbac	Role, RoleBinding
ensure_airflow_group_roles	ServiceAccount, ConfigMap, RoleBinding, CronJob
ensure_access_sync	ServiceAccount, ConfigMap, Role, RoleBinding, CronJob
ensure_identity	ConfigMap stardelt-identity (keeps its dry_run: false)

controller.rs passes &owner at the seven call sites in reconcile_platform; 18 test call sites pass &owner(). One new test, the_access_sync_cron_job_carries_the_platform_instance_owner_reference.

Deliberately untouched: ensure_kafka_broker, ensure_trino_config_maps, ensure_trino_tls, ensure_catalog_principals, Secrets, PVCs, CNPG Clusters/ScheduledBackups.

Checks

cargo fmt --check                                 => ok
cargo clippy --all-targets -- -D warnings         => Finished (no warnings)
cargo test the_access_sync_cron_job_carries_the_platform_instance_owner_reference
                                                  => 1 passed; 0 failed; 630 filtered out
cargo test                                        => 631 passed; 0 failed (values_cli: 8 passed)
cargo run --bin crdgen && git diff --exit-code chart/crds schemas => no diff
awk '/pub async fn ensure_(...)/,/^}/' ... | grep -c "apply::<" => 0
grep -c "apply_owned::<" provision.rs             => 28

The ticket's grep -c "apply_owned::<" => 21 is advisory; measured on origin/main at 08d29fa it is 9 before and 28 after (9 + 19 new call sites). The binding check — no apply::< left in the seven functions — is 0.

Mutation check: with own(&mut object, owner) removed from apply_owned, the new test fails (assertion left == right failed at the kind assert); restored.

Remaining

Nothing in this slice.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.