Skip to content

apollo_integration_tests: delete dead code (unsure, review carefully) #15190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asaf-sw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

apollo_integration_tests: delete dead code (unsure, review carefully) #15190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions crates/apollo_integration_tests/src/integration_test_manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ use crate::monitoring_utils::{
await_batcher_block,
await_block,
await_sync_block,
await_txs_accepted,
get_consensus_decisions_reached,
sequencer_num_accepted_txs,
verify_txs_accepted,
Expand Down Expand Up @@ -751,14 +750,6 @@ impl IntegrationTestManager {
self.rpc_verify_class_declared(BLOCK_TO_WAIT_FOR_DECLARE).await;
}

pub async fn await_txs_accepted_on_all_running_nodes(&mut self, target_n_txs: usize) {
self.perform_action_on_all_running_nodes(|running_node| {
let monitoring_client = running_node.node_setup.state_sync_monitoring_client();
await_txs_accepted(monitoring_client, running_node.get_node_index(), target_n_txs)
})
.await;
}

/// This function tests and verifies the integration of the transaction flow.
///
/// # Parameters
Expand Down Expand Up @@ -1042,11 +1033,6 @@ impl IntegrationTestManager {
.await
}

/// This function returns the number of accepted transactions on all running nodes.
pub async fn get_num_accepted_txs_on_all_running_nodes(&self) -> HashMap<usize, usize> {
self.get_num_accepted_txs_on_running_nodes(&self.get_running_node_indices()).await
}

pub async fn assert_no_reverted_txs_on_all_running_nodes(&self) {
self.perform_action_on_all_running_nodes(|running_node| async move {
let sequencer_idx = running_node.get_node_index();
Expand Down
Loading