[6.x] Bard fields use language for fields, browser direction for labels/instructions#14893
Closed
edalzell wants to merge 9 commits into
Closed
[6.x] Bard fields use language for fields, browser direction for labels/instructions#14893edalzell wants to merge 9 commits into
edalzell wants to merge 9 commits into
Conversation
edalzell
changed the title
edalzell
changed the title
Watch the documentElement dir attribute with a shared MutationObserver so the computed updates live when the direction changes, rather than reading a non-reactive DOM property once. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Reuse useUiDirection for the fallback so the site direction still takes precedence but the browser/UI direction logic lives in one place. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Return the direction under a `direction` key so consuming components can bind it directly. Container aliases it to keep its own combined direction. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Make the direction composable available to addons via the core export, so they can respect the control panel UI direction in custom components. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
|
Gonna hit this from a different angle. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed that the bard fields had all text, including the labels etc where ltr, even when the browser is set to ltr.
I think it's better to have those based on the browser.
Not sure if this should be configurable?