Repository navigation
Conversation
A SOP file named "...sop.md" in an external SOP directory derives
sop_name == "..", since Path("...sop.md").stem is "...sop" and
".removesuffix(".sop")" strips down to "..". skills.py's
_create_skill_file then joins that name directly onto the output
directory (output_path / skill_name) before writing SKILL.md,
escaping the intended output directory by one level with
attacker-controlled content.
Reject any name that isn't a plain, single path component at the
point it's derived, so every consumer (skills.py, cursor.py, mcp.py)
is protected, and add a regression test.
carfeii
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
duplicate - to close