Skip to content

Improved resolution along saturation curve in two-phase tables - #26

Merged
EvertBunschoten merged 8 commits into
developfrom
feature_saturation_curve_interpolator
Aug 26, 2026
Merged

EvertBunschoten merged 8 commits into
developfrom
feature_saturation_curve_interpolator

Conversation

@EvertBunschoten

@EvertBunschoten EvertBunschoten commented Aug 26, 2026

Copy link
Copy Markdown
Member

Proposed Changes

To accurately model phase transitions, it is very important that the saturation curve in the look-up table has a high resolution. In the previous version, this was done by sampling a fixed number of points along the saturation curve. However, points were filtered from the saturation curve due to an issue with the algorithm that clips the points along the saturation curve to the bounds of the table. The robustness of this algorithm is now improved, which filters fewer points from the saturation curve, resulting in a higher resolution.

PR Checklist

Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.

  • I am submitting my contribution to the develop branch.
  • I have updated the list of python modules in required_packages.txt and environment.yml, if necessary.
  • I have properly commented my changes.
  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I have updated the documentation, if necessary.
  • I have added a test case that demonstrates my contribution, if necessary.

@EvertBunschoten EvertBunschoten self-assigned this Aug 26, 2026
@EvertBunschoten EvertBunschoten added bug Something isn't working enhancement New feature or request labels Aug 26, 2026
@EvertBunschoten
EvertBunschoten merged commit 479dce5 into develop Aug 26, 2026
4 checks passed
@EvertBunschoten
EvertBunschoten deleted the feature_saturation_curve_interpolator branch August 26, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant