Make the room pill a bit more dynamic - #169
Merged
Merged
Conversation
lukaaas176
changed the title
Owner
|
Is there a reason why you set a minimum width? When that happens, the room capsule ends up looking wider when the room name doesn't fill the space. 
Just increasing the maxWidth to 280 and leaving minWidth unspecified lets the view naturally constrain itself to the smallest size necessary. 
|
Contributor
Author
|
Ah well, somehow I did not get a notification, sorry about that! Honestly, i felt it was kinda crammed in there, and thought this would be a reasonable default, but I can remove it, sorry for just dropping it in... It just was nice to have "room" to press |
Removed minWidth constraint to allow the title to naturally hug its contents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the room pill a principal toolbar item and set the minimum width to the current maximum width, and increasing the maximum width to 280pt.
Before
After
With less width