Repository navigation
fix: don't delete the last node when adjacent comments precede <script> - #560
Merged
dummdidumm merged 1 commit intoNov 17, 2026
Merged
Conversation
removeAndGetLeadingComments pushes a placeholder text node for adjacent comments. The placeholder is not in the fragment, so splice(indexOf(...), 1) became splice(-1, 1) and removed the last node of the markup. Skip the splice when the node is not found. Fixes sveltejs#555 Assisted-by: Kiro (Claude)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #555
When two comments with no whitespace between them sit right above
<script>or<style>,removeAndGetLeadingCommentsadds a placeholder text node (start: -1) for the missing newline. That placeholder is not inast.fragment.nodes, sosiblings.splice(siblings.indexOf(text), 1)becomessplice(-1, 1)and removes the last node of the markup.This skips the splice when the node is not found, as suggested in the issue.
Added
test/formatting/samples/adjacent-comments-above-scriptusing the multi-node repro from the issue. Onmainit fails with<p>z</p>missing from the output; with the fix the full suite passes (310 tests).