Skip to content

chore: pin vitest to v4 while node 20 is tested in CI - #1439

Merged
manuel3108 merged 2 commits into
mainfrom
chore/pin-vitest-4
Nov 17, 2026
Merged

manuel3108 merged 2 commits into
mainfrom
chore/pin-vitest-4

Conversation

@teemingc

@teemingc teemingc commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

#1402 bumped vitest from v4 to v5, but vitest 5 declares engines.node as ^22.12.0 || ^24.0.0 || >=26.0.0, while this repo declares ^20.19 || ^22.12 || >=24 and .github/workflows/ci.yml still runs the test matrix on Node 20 and 20.19.

Because those jobs run an unsupported vitest, they break as soon as a test fails: vitest's reporter calls Map.groupBy, which Node 20 lacks, so the run crashes with TypeError: Map.groupBy is not a function instead of reporting the failure (seen on #1438).

This PR moves it back to Vitest 4

@teemingc

Copy link
Copy Markdown
Member Author

@copilot resolve the merge conflicts in this pull request

# Conflicts:
#	pnpm-lock.yaml

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

Copilot AI commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved in merge commit 2a3276f. The frozen lockfile install and unit tests pass; Node 20 validation remains for CI.

@manuel3108
manuel3108 merged commit 8931f9d into main Nov 17, 2026
7 checks passed
@manuel3108
manuel3108 deleted the chore/pin-vitest-4 branch November 17, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants