Remove vestigial ESLint config dependencies - #141
Merged
Merged
Conversation
tbroadley
force-pushed
the
fix-eslint-peer-deps
branch
from
September 6, 2026 20:55
e514b4e to
fab9b90
Compare
`eslint-config-airbnb-base` and `eslint-plugin-import` were left over from the old `.eslintrc.yml` setup. The active flat config (`eslint.config.js`) does not reference either package, and ESLint 10 no longer reads eslintrc files at all, so the config file and both dependencies were dead weight. Neither package has a release whose peer range includes ESLint 10 (eslint-config-airbnb-base@15.0.0 allows ^7.32.0 || ^8.2.0; eslint-plugin-import@2.32.0 allows up to ^9), so removing them is the only way to clear the warnings, and it costs no rule coverage since the flat config never loaded them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
tbroadley
force-pushed
the
fix-eslint-peer-deps
branch
from
September 6, 2026 20:58
fab9b90 to
e015aca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
yarn installprinted two peer-dependency warnings:What was vestigial vs. used
Both packages are vestigial. They were only ever referenced by
.eslintrc.yml(extends: airbnb-base,plugin:import/typescript, and theimport/*rules). The repo has since moved to a flat config, andeslint.config.jsdoes not reference either package — it composes@eslint/jsrecommended,@typescript-eslintrecommended, and a handful of custom rules. ESLint 10 no longer reads eslintrc files at all, so.eslintrc.ymlwas dead config and is removed here too.Why not upgrade instead
No published release of either package supports ESLint 10:
eslint-config-airbnb-base— latest is 15.0.0, peer rangeeslint@^7.32.0 || ^8.2.0eslint-plugin-import— latest is 2.32.0, peer range tops out ateslint@^9Since the flat config never loaded them, removing them costs zero rule coverage.
Changes
eslint-config-airbnb-baseandeslint-plugin-importfromdevDependencies.eslintrc.yml.eslintrc.ymlreference from a comment ineslint.config.js## [Unreleased]CHANGELOG entryVerification
yarn install— clean, no peer-dependency warningsyarn ci— spellcheck clean, lint clean, 101 mocha tests passing.tsfile with unused vars and an undefined identifier was flagged by@typescript-eslint/no-unused-varsandno-undef, then removed. The config is not silently linting nothing.🤖 Generated with Claude Code