Repository navigation
chore: Node 22 (Node 20 is EOL) + shell-quote critical CVE fix - #17
Merged
Merged
Conversation
…-quote ≥1.8.5 (CVE-2026-9277 critical) The tar critical (≤7.5.20 via @expo/cli + cacache) is NOT overridden: tar 7 breaks `expo prebuild` ("Cannot read properties of undefined (reading 'extract')", reproduced), which the Android/iOS release builds need. It is build-time only; it clears with an Expo SDK upgrade. Checked on Node 22: typecheck, lint (0 errors), expo export --platform web, expo prebuild android. npm audit: critical 2 → 1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters: 1
📒 Files selected for processing: 6
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
Author
|
Merged by vale. Gates:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From realmwatch-e5's fleet audit (2026-10-21, internet-facing table): forage.techempower.org's
.nvmrcpinned Node 20 (EOL 2026-04-30), andnpm auditshowed 2 critical vulnerabilities.Changes
.nvmrcandsetup-nodein ci / deploy-web / release / sync-data: 20 → 22.overrides.shell-quote: ^1.8.5(resolves to 1.12.0; CVE-2026-9277; vulnerable ≤1.8.4). Consumers are React Native CLI tools and react-devtools-core, which are dev and build tooling, not in the web bundle.tar(critical, ≤7.5.20 via @expo/cli and cacache). Overriding to tar 7 breaksexpo prebuild("Cannot read properties of undefined (reading 'extract')", reproduced), and the release builds need prebuild. It's build-time only and clears with an Expo SDK upgrade.Checked locally on Node 22
npm cifrom the lockfile;npm run typecheck;npm run lint(0 errors);npx expo export --platform web(the deploy command);npx expo prebuild --platform android --no-install --clean(the positive control: it fails under tar 7 and passes with tar 6.2.1).npm audit: critical 2 → 1.Not changed: EAS remote build workers.
eas.jsonpins no Node version, so EAS keeps its image default;release.yml's Node only affects the runner that calls eas-cli.Reviews
npm ci, export run, consumers listed); item 3 is the EAS note.Merged by vale after CI.
🤖 Generated with Claude Code