chore: implement twilio-external-task Lambda [CHI-3955] - #4655
Merged
Conversation
gpaoloni
marked this pull request as ready for review
September 2, 2026 16:12
stephenhand
approved these changes
Sep 2, 2026
| try { | ||
| console.debug(`Authenticating against key ${externalTaskApiKeyParam} `); | ||
| const requestSecret = authorization.replace('Basic ', ''); | ||
| const externalTaskApiKey = await getSsmParameter(externalTaskApiKeyParam); |
Collaborator
There was a problem hiding this comment.
Might be better to move this call out of the try / catch block so we don't get misleading 403s for a configuration issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the Lambda introduced by https://github.com/techmatters/infrastructure-config/pull/588.
Description
This PR implements twilio-external-task:
external_taskchannel type task in the target Twilio account.Example request:
where
external_task_api_keyis the SSM parameter that corresponds to the AS development account sid.Configuration
To test the integration, other than applying the linked PR in infra and deploying this code
/<environment>/twilio/<account_sid>/external_task_api_keyparameter. Make sure is only number (lower and upper case) and numbers. E.g./development/twilio/ACd8a2e89748318adf6ddff7df6948deaf/external_task_api_keyexternalchannel type.Checklist
Other Related Issues
None
Verification steps
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P