Repository navigation
refactor: require disjoint DecompressTo buffers - #13
Merged
ChillerDragon merged 1 commit intoAug 20, 2026
Merged
Conversation
Member
|
e okay? Xd |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #12.
Change
DecompressTonow explicitly requiresdstanddatato use disjoint backing storage. Passing aliased or overlapping slices is invalid API use.This removes the runtime overlap detector, its
unsafeimport and address arithmetic. It deliberately does not replace them withreflect. The overlap-specific tests are removed because overlap is no longer a supported contract.Normal append-style buffer reuse remains unchanged and allocation-free when input and output buffers are distinct.
Rationale
Aliasing compressed input with writable output storage is a caller error and is not needed by the Teeworlds/DDNet packet path. Making that precondition explicit keeps the hot path simple, avoids architecture-dependent address inspection, and removes the exceptional source copy.
Verification
go test ./...go test -race ./...go test -gcflags=all=-d=checkptr=2 ./...go vet ./...staticcheck ./...upstream/master: 0.52% lower geomean time; allocation counts unchanged