Reject update-options --start-delay for workflow Activities - #1150
Merged
Conversation
Only a Standalone Activity has a start delay, and update-options documents --start-delay as unsupported for workflow Activities. The server nonetheless accepts the field for one: the request exits 0 and the response echoes the requested delay, while the stored options leave start_delay unset and the Activity's retry schedule is unchanged. Reject the flag when combined with --workflow-id or --query instead of reporting a change that never happened. Run the tests from the repo root: go test ./internal/temporalcli -run 'TestSharedServerSuite/TestActivity'
spkane31
approved these changes
Aug 3, 2026
| } | ||
|
|
||
| func (s *SharedServerSuite) TestActivityUpdateOptions_StartDelayRejectedForWorkflowActivity() { | ||
| run := s.waitActivityStarted() |
Contributor
There was a problem hiding this comment.
nit: these are client side validations so you don't even need to start an activity.
Contributor
Author
There was a problem hiding this comment.
Thanks, good point, done.
dandavison
enabled auto-merge
August 4, 2026 23:24
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Reject update-options --start-delay for workflow Activities
Tests
SharedServerSuite)