Skip to content

fix(translate): simplify float literal recognition #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tetsuo-cpp merged 1 commit into from
Aug 15, 2026
Merged

fix(translate): simplify float literal recognition #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 5 additions & 18 deletions lib/Translation/ForthToMLIR/ForthToMLIR.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,20 +137,8 @@ bool ForthLexer::isFloat(const std::string &str) const {
if (str.empty())
return false;

// Try to parse as a double. A valid float must contain a '.' or 'e'/'E'.
bool hasDotOrExp = false;
for (char c : str) {
if (c == '.' || c == 'e' || c == 'E') {
hasDotOrExp = true;
break;
}
}
if (!hasDotOrExp)
return false;

char *end = nullptr;
std::strtod(str.c_str(), &end);
return end == str.c_str() + str.size();
double value;
return llvm::to_float(str, value);
}

Token ForthLexer::nextToken() {
Expand Down Expand Up @@ -179,11 +167,10 @@ Token ForthLexer::nextToken() {

std::string text(tokenStart, curPtr - tokenStart);
Token::Kind kind;
if (isFloat(text)) {
kind = Token::Kind::Float;
// Don't uppercase float tokens (preserve original text for strtod)
} else if (isNumber(text)) {
if (isNumber(text)) {
kind = Token::Kind::Number;
} else if (isFloat(text)) {
kind = Token::Kind::Float;
} else {
kind = Token::Kind::Word;
text = toUpperCase(text);
Expand Down
Loading