Skip to content

fix(github): fall back to the latest stable release when page 1 is all pre-releases - #343

Open
thejaustin wants to merge 1 commit into
mainfrom
feature/github-latest-stable-fallback
Open

thejaustin wants to merge 1 commit into
mainfrom
feature/github-latest-stable-fallback

Conversation

@thejaustin

Copy link
Copy Markdown
Owner

GitHub returns at most 100 releases per request. A repo that ships many pre-releases (Shizuku+: 100 of 100 on page 1 are pre-releases) pushes its latest stable release off that page, so with "Include prereleases" off, the default when adding or importing, nothing qualified and adding the app failed with "Could not find a suitable release".

When nothing qualifies, pre-releases are excluded, and /releases/latest wasn't already fetched, this asks /releases/latest and runs it through the same filters, including the minimum-age loop. /tags lookups are untouched.

CI on feature/github-latest-stable-fallback: Lint and Test ✅, Build ✅ (dev build). Not tried on a device yet. The same fix is offered upstream as bikram-agarwal#375.

🤖 Generated with Claude Code

…l pre-releases

GitHub returns at most 100 releases per request. A repo that ships many
pre-releases (e.g. thejaustin/ShizukuPlus: 100 of 100 are pre-releases, the
latest stable is older) pushed its stable release off that page, so with
"Include prereleases" off - the default when adding or importing an app -
nothing qualified and adding the app failed with "Could not find a suitable
release". When nothing qualifies, ask /releases/latest and run it through
the same filters.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-authored-by: Claude <81847+claude@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant