Repository navigation
fix(github): fall back to the latest stable release when page 1 is all pre-releases - #343
Open
thejaustin wants to merge 1 commit into
Open
thejaustin wants to merge 1 commit into
thejaustin wants to merge 1 commit into
Conversation
…l pre-releases GitHub returns at most 100 releases per request. A repo that ships many pre-releases (e.g. thejaustin/ShizukuPlus: 100 of 100 are pre-releases, the latest stable is older) pushed its stable release off that page, so with "Include prereleases" off - the default when adding or importing an app - nothing qualified and adding the app failed with "Could not find a suitable release". When nothing qualifies, ask /releases/latest and run it through the same filters. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Claude <81847+claude@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub returns at most 100 releases per request. A repo that ships many pre-releases (Shizuku+: 100 of 100 on page 1 are pre-releases) pushes its latest stable release off that page, so with "Include prereleases" off, the default when adding or importing, nothing qualified and adding the app failed with "Could not find a suitable release".
When nothing qualifies, pre-releases are excluded, and
/releases/latestwasn't already fetched, this asks/releases/latestand runs it through the same filters, including the minimum-age loop./tagslookups are untouched.CI on
feature/github-latest-stable-fallback: Lint and Test ✅, Build ✅ (dev build). Not tried on a device yet. The same fix is offered upstream as bikram-agarwal#375.🤖 Generated with Claude Code