Conversation
added 2 commits
July 13, 2026 10:18
…: improve sentence list table UX
…: improve sentence list table UX
Member
|
Could you update the docs for this tab in French and English too? |
svndrine
marked this pull request as draft
July 13, 2026 14:09
added 4 commits
July 15, 2026 11:19
…: improve sentence list table UX # Conflicts: # bot/admin/web/src/app/shared/components/sentence-training/sentence-training-entry/sentence-training-entry.component.scss
…: delete de statusColor
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Language Understanding “Search sentences” experience in Tock Studio by renaming it to “All sentences” and refactoring the sentence list header/actions layout for clearer, more consistent interactions.
Changes:
- Renames “Search sentences” to “All sentences” across UI (header/menu) and documentation.
- Refactors sentence list header (select-all labeling, sort control layout) and sentence entry quick-actions/actions grid styling.
- Removes per-status inline coloring by deleting
Sentence.statusColor()and relying on standard text styling.
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/docs/en/user/studio/nlu.md | Renames the documentation section to “The All tab”. |
| bot/admin/web/src/app/shared/components/sentence-training/sentence-training.component.scss | Styles the select-all checkbox label in the grid header. |
| bot/admin/web/src/app/shared/components/sentence-training/sentence-training.component.html | Adjusts header layout (select-all label, sort UI). |
| bot/admin/web/src/app/shared/components/sentence-training/sentence-training-entry/sentence-training-entry.component.scss | Reworks entry layout styling (actions grid + quick actions). |
| bot/admin/web/src/app/shared/components/sentence-training/sentence-training-entry/sentence-training-entry.component.html | Refactors entry header/quick actions and reorganizes tools/actions UI. |
| bot/admin/web/src/app/shared/components/sentence-training/sentence-training-dialog/sentence-training-dialog.component.html | Minor template whitespace changes. |
| bot/admin/web/src/app/model/nlp.ts | Removes Sentence.statusColor() method. |
| bot/admin/web/src/app/language-understanding/sentences/sentences-all/sentences-all.component.ts | Renames component class and updates template/style references. |
| bot/admin/web/src/app/language-understanding/sentences/sentences-all/sentences-all.component.spec.ts | Updates spec to target renamed component (but still needs describe name update). |
| bot/admin/web/src/app/language-understanding/sentences/sentences-all/sentences-all.component.scss | Adds stylesheet file (currently header-only). |
| bot/admin/web/src/app/language-understanding/sentences/sentences-all/sentences-all.component.html | Updates page title to “All sentences”. |
| bot/admin/web/src/app/language-understanding/language-understanding.module.ts | Switches module declaration/import from Search to All component. |
| bot/admin/web/src/app/language-understanding/language-understanding-routing.module.ts | Routes /language-understanding/search to the All component. |
| bot/admin/web/src/app/bot-admin-app.component.ts | Updates navigation label to “All sentences”. |
Suppressed comments (1)
bot/admin/web/src/app/language-understanding/sentences/sentences-all/sentences-all.component.spec.ts:21
- The test suite name still refers to the old component, which makes it harder to find/interpret failures after the rename.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+107
to
+115
| <span | ||
| class="pointer d-flex align-items-center" | ||
| (click)="toggleSort()" | ||
| nbTooltip="Sort by creation date" | ||
| data-testid="sort" | ||
| > | ||
| <nb-icon [icon]="isSorted ? 'sort-down-alt' : 'sort-up-alt'" style="margin-right: 4px"></nb-icon> | ||
| Sort by creation date | ||
| </span> |
| <div class="font-size-small text-muted unselectable d-flex justify-content-end align-items-center mt-auto pr-3"> | ||
| <div> | ||
| <time>{{ sentence.creationDate | date: 'd MMMM yyyy' }}</time> | ||
| <span class="text-uppercase mx-1" nbTooltip="Sentence status"> |
Comment on lines
+88
to
+92
| <div class="config-section d-flex flex-column gap-1"> | ||
| <div class="d-flex"> | ||
| <nb-form-field class="mb-0 flex-grow-1" nbTooltip="Intent association"> | ||
| <nb-icon nbPrefix icon="compass"></nb-icon> | ||
| <input |
| } | ||
|
|
||
| &:hover { | ||
| background: rgba(143, 155, 179, 0.12) !important; |
| } | ||
|
|
||
| &:active { | ||
| background: rgba(143, 155, 179, 0.22) !important; |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Context & Fixes
This PR addresses several UX and structural issues identified in the "Search sentences" section: