Skip to content

Move two Enterprise-only CR reads behind variant extensions - #5200

Merged
caseydavenport merged 2 commits into
tigera:masterfrom
caseydavenport:casey-istio-policysync
Aug 20, 2026
Merged

Move two Enterprise-only CR reads behind variant extensions#5200
caseydavenport merged 2 commits into
tigera:masterfrom
caseydavenport:casey-istio-policysync

Conversation

@caseydavenport

@caseydavenport caseydavenport commented Aug 14, 2026

Copy link
Copy Markdown
Member

Description

Split out of #5170 to keep that review smaller. Two places in core read an Enterprise-only CR to decide what to render:

  • the istio controller fetched the ApplicationLayer CR to work out whether policySyncPathPrefix was needed, and now asks its extension instead
  • the webhooks and apiserver renders took the ManagementCluster CR directly, and now take the tunnel address and secret name as plain values

Same rendering on both variants. The Typha read that started out in this PR went in separately with #5189.

Related: CORE-13395

Release Note

None

Typha, the istio policy-sync prefix, and the webhooks management-cluster
config now take plain values instead of reading Enterprise CRs in core.
@caseydavenport
caseydavenport force-pushed the casey-istio-policysync branch from e0da8f5 to 2319a01 Compare August 18, 2026 21:40
@caseydavenport caseydavenport changed the title Move three Enterprise-only CR reads behind variant extensions Move two Enterprise-only CR reads behind variant extensions Aug 19, 2026
The address is only read in the Enterprise webhook args, so the two fields do not
belong in one type.
@caseydavenport
caseydavenport merged commit 1342e33 into tigera:master Aug 20, 2026
8 of 9 checks passed
@caseydavenport
caseydavenport deleted the casey-istio-policysync branch August 20, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants