Move two Enterprise-only CR reads behind variant extensions - #5200
Merged
caseydavenport merged 2 commits intoAug 20, 2026
Conversation
caseydavenport
force-pushed
the
casey-istio-policysync
branch
from
August 18, 2026 16:42
c938271 to
e0da8f5
Compare
Typha, the istio policy-sync prefix, and the webhooks management-cluster config now take plain values instead of reading Enterprise CRs in core.
caseydavenport
force-pushed
the
casey-istio-policysync
branch
from
August 18, 2026 21:40
e0da8f5 to
2319a01
Compare
The address is only read in the Enterprise webhook args, so the two fields do not belong in one type.
Brian-McM
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split out of #5170 to keep that review smaller. Two places in core read an Enterprise-only CR to decide what to render:
Same rendering on both variants. The Typha read that started out in this PR went in separately with #5189.
Related: CORE-13395
Release Note