Move the whisker non-Calico cleanup behind an Enterprise modifier - #5228
Open
caseydavenport wants to merge 1 commit into
Open
Move the whisker non-Calico cleanup behind an Enterprise modifier#5228caseydavenport wants to merge 1 commit into
caseydavenport wants to merge 1 commit into
Conversation
caseydavenport
force-pushed
the
casey-whisker-extension
branch
from
August 21, 2026 16:05
de5eb30 to
d3fa875
Compare
The whisker render produces the same objects for both variants.
caseydavenport
force-pushed
the
casey-whisker-extension
branch
from
August 21, 2026 19:15
d3fa875 to
8bede35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The whisker render was deleting everything it produced when the variant wasn't Calico, which put variant knowledge in a base render package. The base render now produces the same objects either way, and the Enterprise extension moves them to the delete list, so an install upgraded from Calico still cleans up after itself.
Related: CORE-13395
Release Note