Auto: sync versions [release-v1.44] - #5229
Conversation
There was a problem hiding this comment.
Pull request overview
Automated sync of Calico IPPool CRD definitions into the operator’s release-v1.44 branch (via make gen-versions), updating the imported CRD YAML used by the operator for versioned CRD distribution.
Changes:
- Tightens the documented blockSize range for IPPools (IPv4: 20–32, IPv6: 116–128).
- Adds additional
x-kubernetes-validationsrules for IPPool CIDR masking, link-local overlap prevention, blockSize bounds, and minimum pool size constraints.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/imports/crds/calico/v3.projectcalico.org/projectcalico.org_ippools.yaml | Updates IPPool schema docs and adds CEL validations for CIDR and blockSize constraints. |
| pkg/imports/crds/calico/v1.crd.projectcalico.org/crd.projectcalico.org_ippools.yaml | Mirrors the same IPPool schema doc update and CEL validations in the v1.crd CRD import. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| description: |- | ||
| The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6. | ||
| The block size must be between 0 and 32 for IPv4 and between 0 and 128 for IPv6. It must also be smaller than | ||
| or equal to the size of the pool CIDR. | ||
| The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller | ||
| than or equal to the size of the pool CIDR. |
| description: |- | ||
| The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6. | ||
| The block size must be between 0 and 32 for IPv4 and between 0 and 128 for IPv6. It must also be smaller than | ||
| or equal to the size of the pool CIDR. | ||
| The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller | ||
| than or equal to the size of the pool CIDR. |
11fa168 to
c881928
Compare
|
Removing "merge-when-ready" label due to new commits |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
pkg/imports/crds/calico/v3.projectcalico.org/projectcalico.org_ippools.yaml:97
- The blockSize description now states it must be between 20–32 (IPv4) / 116–128 (IPv6), but the schema/validations explicitly allow blockSize=0 (and omitting the field) as a valid way to use the default block size. This makes the CRD documentation misleading.
description: |-
The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6.
The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller
than or equal to the size of the pool CIDR.
pkg/imports/crds/calico/v1.crd.projectcalico.org/crd.projectcalico.org_ippools.yaml:72
- The blockSize description now states it must be between 20–32 (IPv4) / 116–128 (IPv6), but the schema/validations explicitly allow blockSize=0 (and omitting the field) as a valid way to use the default block size. This makes the CRD documentation misleading.
description: |-
The block size to use for IP address assignments from this pool. Defaults to 26 for IPv4 and 122 for IPv6.
The block size must be between 20 and 32 for IPv4 and between 116 and 128 for IPv6. It must also be smaller
than or equal to the size of the pool CIDR.
Automated sync of versions and CRDs from Calico and Calico Enterprise into
release-v1.44viamake gen-versions.Triggered by scheduled workflow.