Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MarkdownTextSplitteracceptsWithCodeBlocks,WithReferenceLinks, andWithJoinTableRows, but recursive contexts lose all three settings. For example, a fenced code block inside a blockquote disappears even withWithCodeBlocks(true). Nested reference links are expanded when expansion is disabled, and quoted tables repeat their header even when rows should be joined.Copy these existing settings when cloning the context. The change also updates the generated Markdown example to preserve the original inline text in nested blocks with the default
ReferenceLinks(false)setting.Regression tests cover top-level and nested blocks, both option values, and document metadata. This is related to #1439, but does not address its separate list-item code-block parsing or heading/chunking behavior.
Validation: Go 1.26.9 on macOS arm64;
go test -race -count=1 -v ./textsplitter ./documentloaders,go vet ./textsplitter ./documentloaders,go build ./..., and golangci-lint v2.9.0. The existing AssemblyAI integration test skips without a service key; no live provider tests were run.Developed with assistance from OpenAI Codex, with separate agent review and public-API checks.