CI: add Ruby head as an informational build - #201
Merged
Merged
Conversation
Add `head` to the test matrix so we get early warning of breakage on upcoming Ruby, while keeping it non-blocking via continue-on-error. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…head puma 3.x's native extension uses the Data_Make_Struct/Data_Get_Struct C macros, which were removed from Ruby's C API in 4.0+, so it no longer compiles on Ruby head. puma 5 uses the TypedData_* API and builds fine. This supersedes the long-stale #193. Adapt the test harness to puma 5: - Rack::Handler::Puma.run now takes keyword options, not a positional hash. - puma de-chunks requests server-side (it deletes Transfer-Encoding and sets Content-Length to the decoded size), so the chunked-upload specs can no longer observe the header. Rework them to assert the file round-trips intact instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Transfer-Encoding is a hop-by-hop header (RFC 7230 3.3.1): a conformant server decodes the chunked framing and never hands the header to the Rack app. webrick and puma 3 leaked it into the env, which the old assertion relied on; puma 5 does not. The previous comment wrongly framed this as puma buffering and setting Content-Length, which is an incidental server detail, not the reason the header is unobservable. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The round-trip rework verified the file arrives intact, but would also pass if Patron buffered the body and sent Content-Length instead of streaming it. The contract these specs exist to protect -- that put_file/post_file stream with Transfer-Encoding: chunked -- is only observable on the wire, because a conformant server decodes the hop-by-hop framing before the app sees it. Add a small raw-socket capture helper (RawRequestCapture, with optional TLS termination using the test certs) and point the chunked specs at it, asserting the request carries Transfer-Encoding: chunked, no Content-Length, and delivers the file intact. This is server-agnostic and immune to the puma de-chunking. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Ruby head to CI as an informational (non-blocking) build so we get early warning of breakage on upcoming Ruby.
To make the head build actually run the suite, bumps the
pumadev dependency from~> 3.11to~> 5.6— puma 3's C extension no longer compiles on Ruby head (it uses C macros removed in Ruby 4.0+). This supersedes the long-stale #193.Changes
ruby-version: "head"added viamatrix.includewithallow-failure: true; job usescontinue-on-errorso a head failure won't block merges. Pinned Rubies (2.4, 3.0, 3.4.1, 4.0.5) stay required.Rack::Handler::Puma.runnow takes keyword options.Transfer-Encodingheader before the app sees it (RFC 7230 §3.3.1), so the old header assertion no longer works. Reworked to capture the raw request over a socket (with optional TLS) and assert Patron streamsTransfer-Encoding: chunkedwith noContent-Length— server-agnostic and testing the real client contract.🤖 Generated with Claude Code