Remove stale cdylib build script - #1
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5964ff7db
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| edition = "2024" | ||
| description = "A dynamic library providing Virtualization-based process isolation capabilities" | ||
| build = "build.rs" | ||
| license = "Apache-2.0" |
There was a problem hiding this comment.
The reviewed commit message has no Signed-off-by: trailer, so it does not satisfy the repository's DCO requirement and may be rejected by the DCO gate. Replace it with an equivalent signed commit before merging.
AGENTS.md reference: AGENTS.md:L119-L119
Useful? React with 👍 / 👎.
| edition = "2024" | ||
| description = "A dynamic library providing Virtualization-based process isolation capabilities" | ||
| build = "build.rs" | ||
| license = "Apache-2.0" |
There was a problem hiding this comment.
The commit title, Remove stale cdylib build script, omits the required <subsystem>: prefix. Rename it to follow the repository's commit-title format, such as libkrun: remove stale cdylib build script.
AGENTS.md reference: AGENTS.md:L117-L117
Useful? React with 👍 / 👎.
| edition = "2024" | ||
| description = "A dynamic library providing Virtualization-based process isolation capabilities" | ||
| build = "build.rs" | ||
| license = "Apache-2.0" |
There was a problem hiding this comment.
This Codex-authored commit has no Assisted-by: trailer, so it omits the repository's required agent attribution. Add an Assisted-by: <Agent-tool>: <model-name> trailer without using Co-authored-by.
AGENTS.md reference: AGENTS.md:L120-L120
Useful? React with 👍 / 👎.
1 participant
Summary
FsDeviceBackendmodel so the 2.0 integration branch's required unit-test workflow can compile and runRoot cause
The Sandbox integration changed
libkrunfromcrate-type = ["cdylib", "lib"]tocrate-type = ["lib"], but retained a build script that emitscargo:rustc-cdylib-link-arg. Cargo therefore warns that the package has no cdylib target and may reject the configuration in a future release.Verification
cargo fmt --all --checkcargo test --lockedcargo clippy --locked -- -D warnings