Repository navigation
chore(issues): archive closed issue #2473 spec to docs/issues/closed - #2485
Conversation
…closed Moves the spec folder, sets status done and related-pr 2481, marks the EPIC torrust#2003 subissue row DONE, and repoints the PR torrust#2474 and PR torrust#2481 audit front matter.
There was a problem hiding this comment.
🔵 Needs a closer look
The manual-verification record’s last-updated timestamp was not advanced when its frontmatter changed.
0 open findings
What changed in this PR
Archives completed issue #2473 and updates its live documentation references.
Changes:
- Moves the issue specification and supporting records to
docs/issues/closed/. - Marks the issue complete and updates EPIC #2003.
- Repairs PR review audit links.
| File | Description |
|---|---|
docs/issues/closed/2473-2003-asynchronous-discussion-rounds/ISSUE.md |
Finalizes and archives the specification. |
docs/issues/closed/2473-2003-asynchronous-discussion-rounds/manual-verification-evidence.md |
Updates the parent-spec path. |
docs/issues/closed/2473-2003-asynchronous-discussion-rounds/agent-review-reports.md |
Updates archived artifact links. |
docs/issues/open/2003-overhaul-guardrails-and-automation/EPIC.md |
Marks subissue #2473 done. |
docs/pr-reviews/pr-2474-review/PR-REVIEW.md |
Updates the specification link. |
docs/pr-reviews/pr-2481-review/PR-REVIEW.md |
Updates the specification link. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
da2ce7
left a comment
da2ce7
left a comment
There was a problem hiding this comment.
Reviewed at 54560694657807dee2b7dec8be5effbe3de35126 (round 1). Recomputed from the bytes at this head, against develop at 40dae98a7.
This PR archives the issue #2473 specification after PR #2481 merged as 40dae98a7. One commit moves the three-file folder to docs/issues/closed/, sets the spec to done, marks row 15 of EPIC #2003, and repoints the PR #2474 and PR #2481 audit records.
Archive against cleanup-completed-issues. Steps 2 and 3 hold for the spec. No open/2473-… folder remains. ISSUE.md:5,9,11,12 set done, the closed spec-path, related-pr: 2481 and "2026-10-08 09:12". 2481 is the implementation PR, which is the choice the related-pr draft records at its :46-49. The stamp matches the 09:12 log entry (:210-214) and the commit time, 09:13:59Z. :178 is ticked. :177 (Committer) stays open and the log gives the reason, which Step 3 allows: it ticks only checkboxes "that reflect completed work", and 2e6460254 also left this one open. The one relative link (ISSUE.md:40) resolves to docs/discussions/AGENTS.md. agent-review-reports.md has no stamp field. manual-verification-evidence.md has one and it was not bumped (F1).
Reference repairs (Step 4). The folder name appears in six files at the head, and every hit names closed/. The base has the same six files, naming open/. No file under docs/discussions/ or docs/templates/, and neither docs/index.md nor docs/AGENTS.md, names the spec. All 34 relative links and frontmatter paths in the six files resolve. The two audit records follow the frontmatter of PR-REVIEW-TEMPLATE.md, which has no stamp, so related-artifacts is the only field that changes.
EPIC #2003 (Step 5). Row 15 (EPIC.md:268) gets the closed path and the " (DONE)" suffix that this table uses (rows 3–5 and 7–9). The table has no Status column. The Dependencies cell is still true. The log entry at :384-385 uses the file's existing actor form, and the stamp is 09:12. Step 0.7's check finds three docs/issues/drafts/2003-* specs with epic: 2003, so "stays open" is correct.
Hygiene. The commit subject matches the form in Step 6 and in 3ab1bd38c, 3127250e6 and 2e6460254. The body matches the diff. Author and committer are the same, there is no trailer, the diff is docs-only, project-words.txt is untouched and git diff --check is clean. The PR body follows the template in Step 7. The GitHub-state claims (the closure, the merge without the EPIC owner's review, Copilot's one finding, the hook runs) are reported here and were not recomputed.
Findings
- F1 [Minor], inline:
manual-verification-evidence.md:4still says2026-10-08 06:50after its frontmatter changed. This finding blocks: the stamp is now false, and the rule in Step 4 is explicit.
Checked, no finding
- The move (3 files at the base, the same 3 at the head), the fields required at
done,related-pr, and the References line:302 - The Committer checkpoint left open, with its reason logged
- The reference grep and the resolution of links and frontmatter paths in all six files
- The EPIC row's suffix and path, the EPIC stamp, the log entry, and the Step 0.7 statement
- Drafts (the tree side of Step 0.6): 30 specs, all with
github-issue: null - Commit form, diff scope, and the scans for whitespace and banned tokens
Checks
On the loop's compute hub at this head, base develop 40dae98a7 (receipt server-gates-krkavec-176): pre-commit profile gate exit 0 (73 s); linter markdown, linter cspell, linter lychee exit 0; frontmatter-validator --all: 19 errors / 4 warnings at this head and 19 / 4 at develop 40dae98a7 re-measured, so no new frontmatter finding. GitHub checks at this head at posting time: "Docs Lint: completed/success". At posting, develop is 40dae98a7.
…t-updated stamp The archive repointed this record's issue-spec frontmatter but left last-updated-utc at its earlier value, which cleanup-completed-issues Step 4 requires updating.
Records da2ce7 review 5454581655 (F1) with its fix, verification, and reply URL.
da2ce7
left a comment
da2ce7
left a comment
There was a problem hiding this comment.
Reviewed at 41cf66d77df718bd7bd536942ff2611f3bb65746 (round 2). Recomputed from the bytes at this head, against develop at 40dae98a7.
The push leaves the round-1 commit unchanged (range-diff =) and adds two commits: the F1 stamp fix and the PR #2485 review audit.
F1, verified fixed. manual-verification-evidence.md:4 now reads last-updated-utc: 2026-10-08 10:14. That is unquoted, like the record's earlier value and the template's :4, and it is no later than the fix commit's author time, 10:15:04Z. The commit changes only that line, and the rest of the record is byte-identical to round 1.
Audit record. The frontmatter follows the template, and its three related-artifacts resolve. The F1 row reads Human / Minor (the posted bracket) / metadata / ORIGINAL / FIXED / RESOLVED. Its Resolution reference is the fix subject, which is unique on the branch. Review 5454581655 owns comment 4217310326, and reply 4217681494 is on the same thread. Reviewer finding ID: N/A is right, because the ID was kept, not reassigned (process-pr-review/SKILL.md:218-219). The log runs 10:13 then 10:15, ending before the 10:16:47Z audit commit. The Copilot paragraph is true: review 5454515898 says "0 open findings", and its one remark ("The manual-verification record's last-updated timestamp was not advanced when its frontmatter changed.") has no request and no thread, so giving it no row follows :51-52. The Status Values block is not verbatim (F2).
Spec and EPIC. No rule moves the spec's 09:12 stamp or its log for a commit that touches only a supplementary record or an audit, and c314e501e likewise changed only an evidence record. The EPIC is untouched.
Hygiene. In both new commits, author = committer (10:15:04Z and 10:16:47Z, after the 09:36:58Z review). Their subjects are Conventional with [#2473], the bodies are true, and there are no trailers. No banned token, project-words.txt is unchanged, git diff --check is clean, and the PR body is unchanged since round 1 and still true.
Findings
- F1 [Minor]: fixed and verified; the thread is resolved.
- F2 [Minor], inline: the record's Category line wraps differently from the template's verbatim block. This blocks, as the same rewrap did on PR #2468.
Checked, no finding
- The range-diff and the scope of both new commits
- The F1 row and detail entry, with the IDs and URLs checked against the capture
- The Copilot paragraph, Ownership and Completion Rules
Checks
On the loop's compute hub at this head, base develop 40dae98a7 (receipt server-gates-krkavec-180): pre-commit profile gate exit 0 (76 s); linter markdown, linter cspell, linter lychee exit 0; frontmatter-validator --all: 19 errors / 4 warnings at this head and 19 / 4 at develop 40dae98a7 re-measured, so no new frontmatter finding; validate-audit-record.py --pr-number 2485 over the live review comments: 1 row, 2 log entries, 0 failures. GitHub checks at this head at posting time: "Docs Lint: completed/success". At posting, develop is 40dae98a7.
…m in the PR torrust#2485 audit The Category item wrapped after documentation, as in the PR torrust#2481 and PR torrust#2474 records it was copied from, instead of after correctness as in the template's verbatim block.
…rust#2487 audit Same defect that da2ce7 raised on the PR torrust#2485 audit (review-finding:pr-2485-f2): the Category item wrapped after documentation instead of after correctness as in the template's verbatim block.
da2ce7
left a comment
da2ce7
left a comment
There was a problem hiding this comment.
Reviewed at 952396ef159fa20aa8073b16a62902bf0439bfc8 (round 3). Recomputed from the bytes at this head, against develop at 40dae98a7.
The push leaves the first three commits unchanged (range-diff =) and adds two audit-only commits: the F2 fix and the record of the round-2 review.
F2, verified fixed. The Category item (PR-REVIEW.md:34-35) now wraps after `correctness`,. Leaving out the template's guidance comment, a diff of the record's Status Values block against the template is empty, and so are the diffs for Completion Rules and for Ownership with N/A in place of its placeholder. The thread is resolved.
Record. The F2 row reads Human / Minor (the posted bracket) / formatting / ORIGINAL / FIXED / RESOLVED. formatting describes the concern, a rewrapped line, and matches the category PR #2468 gave the same rewrap. Review 5455225153 owns comment 4217825381, and reply 4217841415 is on the same thread. The Resolution reference is the fix subject, which is unique on the branch. Reviewer finding ID: N/A is right: the ID was kept, not reassigned (process-pr-review/SKILL.md:218-219), the same as F1's entry. The new Findings paragraph matches reviews.json (CHANGES_REQUESTED, 10:31:21Z). The log runs 10:13, 10:15 and 10:33, ending before the 10:34:05Z commit.
Hygiene. In all five commits, author = committer. The two new commits come in order after the 10:31:21Z review, have Conventional subjects with [#2473] and no trailers, and the one body present is true. No banned token, git diff --check is clean, and the PR body is unchanged.
Findings
- F1 [Minor] and F2 [Minor]: fixed and verified. No new findings.
Checked, no finding
- The range-diff, and that the new commits touch only the audit record
- Status Values, Completion Rules and Ownership against the template
- The F2 row and detail entry, with the IDs and URLs checked against the capture
- The Findings paragraph and the log order
Checks
On the loop's compute hub at this head, base develop 40dae98a7 (receipt server-gates-krkavec-184): pre-commit profile gate exit 0 (91 s); linter markdown, linter cspell, linter lychee exit 0; frontmatter-validator --all: 19 errors / 4 warnings at this head and 19 / 4 at develop 40dae98a7 re-measured, so no new frontmatter finding; validate-audit-record.py --pr-number 2485 over the live review comments: 2 rows, 3 log entries, 0 failures. GitHub checks at this head at posting time: "Docs Lint: completed/success". At posting, develop is 40dae98a7.
|
ACK 952396e — Status Values block byte-identical to the template, two-row audit record (F1, F2) verified cell by cell against the capture, first three commits unchanged by range-diff |
|
ACK 952396e |
…rust#2487 audit Same defect that da2ce7 raised on the PR torrust#2485 audit (review-finding:pr-2485-f2): the Category item wrapped after documentation instead of after correctness as in the template's verbatim block.
Archives the spec for issue #2473 (closed on GitHub by PR #2481) from
docs/issues/open/todocs/issues/closed/.CLOSEDon GitHub; it was the only spec indocs/issues/open/whose issue is closed, and no draft carries a GitHub issue number.status: done,spec-path,related-pr: 2481,last-updated-utc) and of itsagent-review-reports.mdandmanual-verification-evidence.md.related-artifactsfront matter of the PR docs(issues): [#2473] specify asynchronous, attributed discussion rounds #2474 and PR docs(discussions): [#2473] hold design discussions as asynchronous, attributed rounds #2481 review audits.frontmatter-validatorexits 0 for every changed file.