Skip to content

Refactor property fetching to Gradle properties #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
faogustavo merged 3 commits into from
Sep 14, 2026
+5 −15
Merged

Refactor property fetching to Gradle properties #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2511228
Refactor property fetching to Gradle properties
cpaleop Jul 20, 2026
4f857f8
Fixed remaining cases that break isolation
faogustavo Sep 11, 2026
794b9b8
ktlint
faogustavo Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions kmmbridge-github/src/main/kotlin/co/touchlab/kmmbridge/github/internal/GithubApi.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import co.touchlab.kmmbridge.findStringProperty
import org.gradle.api.Project

internal val Project.githubPublishTokenOrNull: String?
get() = project.property("GITHUB_PUBLISH_TOKEN") as String?
get() = project.findStringProperty("GITHUB_PUBLISH_TOKEN")

internal val Project.githubPublishUser: String?
get() = project.findStringProperty("GITHUB_PUBLISH_USER")
Expand All @@ -37,10 +37,8 @@ internal val Project.githubRepoOrNull: String?

internal val Project.githubPublishToken
get() =
(
project.property("GITHUB_PUBLISH_TOKEN")
?: throw IllegalArgumentException("KMMBridge Github operations need property GITHUB_PUBLISH_TOKEN")
) as String
project.findStringProperty("GITHUB_PUBLISH_TOKEN")
?: throw IllegalArgumentException("KMMBridge Github operations need property GITHUB_PUBLISH_TOKEN")

internal val Project.githubArtifactReleaseId
get() = project.findStringProperty("GITHUB_ARTIFACT_RELEASE_ID")
Expand Down
2 changes: 1 addition & 1 deletion kmmbridge-gitlab/src/main/kotlin/co/touchlab/kmmbridge/gitlab/internal/GitLabApi.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import java.net.URLEncoder
import org.gradle.api.Project

internal val Project.gitLabPublishTokenOrNull: String?
get() = project.property("GITLAB_PUBLISH_TOKEN") as String?
get() = project.findStringProperty("GITLAB_PUBLISH_TOKEN")

internal val Project.gitLabPublishUser: String?
get() = project.findStringProperty("GITLAB_PUBLISH_USER")
Expand Down
10 changes: 1 addition & 9 deletions kmmbridge/src/main/kotlin/co/touchlab/kmmbridge/ProjectExtensions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,9 @@
package co.touchlab.kmmbridge

import org.gradle.api.Project
import org.gradle.api.plugins.ExtraPropertiesExtension
import org.gradle.api.publish.PublishingExtension
import org.gradle.kotlin.dsl.getByType

val Project.publishingExtension get() = extensions.getByType<PublishingExtension>()

fun Project.findStringProperty(name: String): String? {
rootProject.extensions.getByType(ExtraPropertiesExtension::class.java).run {
if (has(name)) {
return get(name).toString()
}
}
return null
}
fun Project.findStringProperty(name: String): String? = providers.gradleProperty(name).getOrNull()
Loading