Local Test Server - #288
Open
faogustavo wants to merge 2 commits into
Open
Conversation
faogustavo
commented
Sep 11, 2026
Contributor
- Instead of using a remote server for tests, use a local version that is started before you run tests
- This allows forks to properly run the entire test suite, as they will not need access to any test secrets
There was a problem hiding this comment.
🟢 Approval recommended
No blocking issues were identified; only minor documentation nits remain.
Pull request overview
This PR replaces the secret-backed remote test artifact service with a local Node.js server, enabling forked CI runs without test secrets.
Changes:
- Adds and starts a local artifact server in CI.
- Updates tests and artifact managers to use localhost.
- Removes obsolete secret handling and documents local setup.
File summaries
| File | Reviewed changes |
|---|---|
TESTING.md |
Documents local server setup. |
kmmbridge/src/test/kotlin/co/touchlab/kmmbridge/SpmLocalDevTest.kt |
Removes remote server properties. |
kmmbridge/src/test/kotlin/co/touchlab/kmmbridge/NonKmmBridgeTasksTest.kt |
Removes remote server properties. |
kmmbridge/src/test/kotlin/co/touchlab/kmmbridge/BasePluginTest.kt |
Removes secret-file loading. |
kmmbridge/src/test/kotlin/co/touchlab/kmmbridge/ArtifactManagerTest.kt |
Validates local artifact URLs. |
kmmbridge-test/src/main/kotlin/Extensions.kt |
Configures the local test manager. |
kmmbridge-test/src/main/kotlin/co/touchlab/kmmbridge/test/TestUploadArtifactManager.kt |
Uses local upload/download endpoints. |
.gitignore |
Removes the obsolete secret ignore rule. |
.github/workflows/build_mac.yml |
Starts and waits for the local server. |
.github/scripts/test-artifact-server.js |
Implements the mock artifact server. The endpoint comment needs correction. |
Review details
- Files reviewed: 9/10 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| * Throwaway stand-in for Touchlab's private test-artifact server (api.touchlab.dev). | ||
| * | ||
| * Implements just the two endpoints KMMBridge's TestUploadArtifactManager needs: | ||
| * POST /store -> stores the request body, returns {"url": "/infoadmin/streamTestZip/<id>.zip"} |
Comment on lines
+13
to
+14
| `ArtifactManagerTest`, `SpmLocalDevTest`, and `NonKmmBridgeTasksTest` upload/download through a mock | ||
| artifact server hardcoded to `http://127.0.0.1:8089` (see `kmmbridge-test`'s `TestUploadArtifactManager`). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.