Skip to content

Add Aikido to the in-kind sponsors - #44

Merged
oalders merged 2 commits into
mainfrom
fix-42
Nov 2, 2026
Merged

oalders merged 2 commits into
mainfrom
fix-42

Conversation

@oalders

@oalders oalders commented Nov 2, 2026

Copy link
Copy Markdown
Member

Closes #42

Changes

  • Adds Aikido as the first card in the ### 2026 grid under ## Sponsors in kind, with the description "CPAN security supported by Aikido." data/sponsors.yaml is unchanged.
  • Adds static/images/aikido.svg, the "aikido dark" logo from Aikido's press kit. It's the press kit's hosted preview file, not the Google Drive download. It reads clearly in the white logo box, so no bgcolor is needed.
  • Links the sponsor name on logo cards to the sponsor's site, using the same href, target and rel as the logo link. The issue expected no template change; this one was requested separately while working on it. It applies to all six logo cards. Cards without a logo render as before.
  • Adds tests/e2e/sponsors.spec.js, which checks the Aikido card's logo link, name link and that the logo loads.

The name links use the site's base link style (inherited colour, underlined), like the linked names on the text-only cards in this grid, so there is no CSS change.

Testing

  • The new test failed before the change: first on the missing card, then on the missing name link. It passes now.
  • ./node_modules/.bin/playwright test: 28 passed on this HEAD.
  • hugo builds cleanly, and the built page has both Aikido links, the description and the logo.
  • Checked the rendered grid at desktop width and at 400px: no overflow, and the logo fits its box.

Declined findings

From /code-review-intense-flow, which reported no Critical or Important findings on the final commit:

  • Two adjacent links to the same URL on each logo card. This follows directly from the requested name link. Hiding the logo link from assistive tech would make it mouse-only, so both stay.
  • Vague description wording. The wording comes from the issue and was edited at the maintainer's request.
  • Asserting target and rel, testing the other logo cards, and adding no-URL, mobile viewport or keyboard focus cases. The links use the template's existing pattern, and these checks would add test weight for little protection on a small template.
  • Role-based link locators and removing the alt assertion. The class selectors are what tell the logo link from the name link, and the assertion is harmless.
  • Root-relative image path. The relative path is existing template behaviour and resolves correctly at /our-sponsors.html.
  • Accent colour for name links. The inherited style matches the other linked names in the grid.
  • SVG <title> and removing width/height. The <img> carries the alt text, and the logo file stays identical to the source.
  • Modelling sponsors in JSON-LD, adding llms.txt, a Content-Security-Policy and an SVG lint in CI. These are site-wide and outside this issue.

🤖 Generated with Claude Code · Opus 5.5

oalders and others added 2 commits November 2, 2026 18:27
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review fix: the spec now selects the Aikido card by identity, not position.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@oalders
oalders marked this pull request as ready for review November 2, 2026 18:38
@oalders
oalders merged commit 51be30a into main Nov 2, 2026
2 checks passed
@oalders
oalders deleted the fix-42 branch November 2, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Aikido to the in-kind sponsors

1 participant