Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review fix: the spec now selects the Aikido card by identity, not position. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42
Changes
### 2026grid under## Sponsors in kind, with the description "CPAN security supported by Aikido."data/sponsors.yamlis unchanged.static/images/aikido.svg, the "aikido dark" logo from Aikido's press kit. It's the press kit's hosted preview file, not the Google Drive download. It reads clearly in the white logo box, so nobgcoloris needed.href,targetandrelas the logo link. The issue expected no template change; this one was requested separately while working on it. It applies to all six logo cards. Cards without a logo render as before.tests/e2e/sponsors.spec.js, which checks the Aikido card's logo link, name link and that the logo loads.The name links use the site's base link style (inherited colour, underlined), like the linked names on the text-only cards in this grid, so there is no CSS change.
Testing
./node_modules/.bin/playwright test: 28 passed on this HEAD.hugobuilds cleanly, and the built page has both Aikido links, the description and the logo.Declined findings
From
/code-review-intense-flow, which reported no Critical or Important findings on the final commit:targetandrel, testing the other logo cards, and adding no-URL, mobile viewport or keyboard focus cases. The links use the template's existing pattern, and these checks would add test weight for little protection on a small template.altassertion. The class selectors are what tell the logo link from the name link, and the assertion is harmless./our-sponsors.html.<title>and removingwidth/height. The<img>carries thealttext, and the logo file stays identical to the source.llms.txt, a Content-Security-Policy and an SVG lint in CI. These are site-wide and outside this issue.🤖 Generated with Claude Code · Opus 5.5