Add support for crypto.Signer backed MLDSA - #274
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
==========================================
- Coverage 82.57% 78.72% -3.85%
==========================================
Files 5 10 +5
Lines 241 940 +699
==========================================
+ Hits 199 740 +541
- Misses 30 107 +77
- Partials 12 93 +81 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
phbnf
approved these changes
Aug 10, 2026
| h := keyHashMLDSA(name, pubKeyBytes) | ||
| s := &subtreeSigner{ | ||
| name: name, | ||
| hash: h, |
Collaborator
Author
There was a problem hiding this comment.
(needs a re-approve)
AlCutter
force-pushed
the
crypto_signer_mldsa
branch
from
August 10, 2026 14:29
3a29f91 to
e627221
Compare
phbnf
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for instantiating an MLDSA cosigner backed by a
crypto.Signer.