Skip to content

New pattern_linewidth aesthetic? #83

Description

@trevorld
  • {ggplot2} is renaming the size aesthetic to linewidth when referring to line widths
  • Should {ggpattern} rename the pattern_size aesthetic to pattern_linewidth when referring to pattern line widths to match the above change?
  • Obviously keep support for pattern_size for backwards compatibility...

Activity

  1. added
    upkeepmaintenance, infrastructure, and similar
    on Jun 17, 2022
  2. trevorld commented on Jun 17, 2022

    @trevorld
    OwnerAuthor

    Perhaps easier if we first support new linewidth parameter in {gridpattern}: trevorld/gridpattern#57

  3. self-assigned this
    on Jun 17, 2022
  4. trevorld commented on Jun 20, 2022

    @trevorld
    OwnerAuthor
    • Development version of {gridpattern} can now handle either using pattern_linewidth or pattern_size (and makes both available to custom patterns).
    • Looking at what {ggplot2} did it seems keeping backwards compatibility for pattern_size would be a "non-trivial" enterprise and currently there aren't any known patterns that need both a pattern_size and pattern_linewidth aesthetic... Leaning towards not adding a new pattern_linewidth aesthetic for now but would be open to backwards-compatible pull requests that implement this...
  5. removed their assignment
    on Jun 20, 2022
  6. changed the title [-]New 'pattern_linewidth' aesthetic?[/-] [+]New `pattern_linewidth` aesthetic?[/+] on Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    upkeepmaintenance, infrastructure, and similar

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions