fix(core,sdk,webapp): allow 10 session trigger tags, matching the run tag limit - #4832
Merged
Conversation
… tag limit
SessionTriggerConfig.tags was capped at 5 while runs accept 10. Since these
tags are forwarded directly as run tags, the cap was inconsistent with the
documented run limit and, for chat.agent, left only 4 user tags after the
automatic chat:{chatId} tag.
🦋 Changeset detectedLatest commit: 512bde9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 27 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 5 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (49)
WalkthroughThe session Merge Risk: 🟡 Moderate · up to The PR raises session trigger tag limits consistently across the SDK, schema, dashboard, and documentation, but required temporary markers are still missing from the new SDK logic and tests; merge should wait until they are added or explicitly accepted. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…he tag length limit All three chat session starters now share one chatRunTags helper. A chat ID too long to fit in a 128-character tag no longer fails session creation; the run just is not filterable by chat.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
matt-aitken
enabled auto-merge (squash)
August 29, 2026 17:55
samejr
approved these changes
Aug 29, 2026
samejr
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SessionTriggerConfig.tagswas capped at 5, while runs (and the tags docs) allow 10. Session trigger tags are forwarded verbatim as the run tags on every run a session schedules, so the lower cap was an inconsistency rather than a separate limit. Forchat.agentit was worse in practice: the SDK prependschat:{chatId}automatically and truncates, so users could only get 4 of their own tags through.The schema, the SDK truncation points, and the dashboard playground now all use 10.
chat.agentusers get 9 of their own tags plus the automaticchat:{chatId}tag. Docs updated to say so.