Repository navigation
Conversation
|
No actionable comments were generated in the recent review.
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Contribution Scope | The workflow fix is linked to #1072 and the description covers preserved compatibility and validation failure behavior. However, the reviewed diff also includes commit 355ea38, which changes `docs/ass… |
Remove the unrelated README animation refresh and its manifest changes from this PR, or move it to a separate PR. If maintainers intentionally retain it, record that scope decision and update the PR description with the second slice, its ra… | |
| Validation Evidence | Evidence covers the port-progress behavior, but the validation record is not current-head accurate. The authoritative refs are base 63c9263 and head 26ae538. The body reports an exact-head CI run for … | Run or link the scoped checks for head 26ae538, at least the generated-artifact, package, and website checks affected by the later refresh; retain the older workflow regression result only as reused evidence because the compiler and regress… |
Full details: Contribution Scope
-
Explanation
The workflow fix is linked to
#1072and the description covers preserved compatibility and validation failure behavior. However, the reviewed diff also includes commit 355ea38, which changesdocs/assets/archify-live-proof.gifand its manifest after Sequence header centering. The latest description says only the compiler, regression test, and canonical ZIP change. It does not explain or scope this second delivery slice. The repository guidance also says to keep unrelated generated output out of the diff.Resolution
Remove the unrelated README animation refresh and its manifest changes from this PR, or move it to a separate PR. If maintainers intentionally retain it, record that scope decision and update the PR description with the second slice, its rationale, and the affected generated files.
Full details: Validation Evidence
-
Explanation
Evidence covers the port-progress behavior, but the validation record is not current-head accurate. The authoritative refs are base 63c9263 and head 26ae538. The body reports an exact-head CI run for 7e8ce82 (and the discussion cites 48717dd), while the evaluated head adds later README/generated refresh commits. The current diff also changes archify.zip, docs/assets/archify-live-proof.gif, and its manifest, contrary to the body’s statement that only the compiler, an existing regression file, and the ZIP changed. Observed evidence is otherwise useful: the new test covers large node and edge widths, both directions, right-side routing, bounded CLI termination, JSON diagnostics, input preservation, and no output; the test runner discovers it automatically; the archived compiler matches the tracked compiler; and the proof manifest hashes match the GIF and classic artifact. The author-reported 295 Workflow tests, 19 smoke cases, comparison matrix, and CI results remain reports from older revisions, not observed final-head results.
Resolution
Run or link the scoped checks for head 26ae538, at least the generated-artifact, package, and website checks affected by the later refresh; retain the older workflow regression result only as reused evidence because the compiler and regression test are unchanged since that run. Update the PR body to name the evaluated base/head, list the actual changed files, and distinguish author-reported, reused, and directly verified evidence.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
tt-a1i
left a comment
There was a problem hiding this comment.
Agent-assisted review; visual inspection and local probes below were performed by agents, not claimed as human acceptance.
Reviewed head b51dda9112fe94d1d874acdf3d150898ae4ff33a against current dev e837dc4cb83042d2b6c596e039692e25ec62c2da.
The progress guard is appropriately scoped: it stops when neither signed probe can change the floating-point coordinate, or the loop increment cannot advance, while preserving the fallback and authored dimensions. I independently reproduced the current-dev timeout at width 1e30 and confirmed that the extracted candidate handles 1e18/1e25/1e26/1e30 and the ordinary 320 control promptly, preserves input bytes, and writes no HTML during validate. Four maintained inputs at both quality profiles retain identical complete compile results. No blocking source defect found. Please keep the PR in Draft until the accountable contributor completes the personal-review confirmation, then synchronize current dev and verify final-head integration CI; no arbitrary dimension limit is requested.
Preserve the finite-port progress guard and its regression while integrating current dev. BlueboxC
|
Refreshed this existing branch against dev The existing regression still exceeds its bounded deadline on current dev. Combined source passes294 Workflow tests and19 core smoke cases, with generated/package checks. Final CI passes16 jobs; full-regression, website and two deployments are normal skips and are not claimed as executed. The technical refresh is complete. Personal review remains unconfirmed, so Draft is retained accurately. BlueboxC |
Advance past repeated representable coordinates without discarding later clear ports. Retain bounded CLI validation and add occupied-center and occupied-neighbour controls. BlueboxC
Preserve rounded clear ports while bounding probes for very wide edges. Extend the existing selector and public CLI regressions and regenerate the canonical ZIP. BlueboxC
Preserve the original correction while regenerating the combined source package. BlueboxC
Recapture the existing scenes from the current gallery artifacts after upstream PR tt-a1i#1173. BlueboxC
Retain the original correction and upstream Sequence centering; bind the animation to the combined gallery artifacts. BlueboxC
Problem and change
Fixes #1072. This revision addresses CodeRabbit's edge-width finding while retaining the earlier occupied-port correction.
With node width
1e30and edge width1e25, occupied port clearance spans an enormous interval. Heade233414still exceeds the bounded public-CLI deadline because representable-coordinate progress alone can require billions of occupied probes.The selector now skips an interval only while both signed directions are blocked, advancing to the earliest possible clearance boundary on the 12px grid. A conservative floating-point margin preserves ports that round clear before the exact mathematical boundary. Existing finite progress, final-slot, clearance and fallback rules remain. Authored dimensions, edge widths, schema limits and routing controls are preserved.
Head:
7e8ce82376ea56d7074676b3d30aafd78264fff4.Parent:
e2334144a0518b192bba74edd3da49f5d16d99de.Base: dev
fdc65ba5f0738aa0316670803c2d29b2e39ee54e.Only the compiler, its existing regression file and the regenerated canonical ZIP change. The published tree is identical to the qualified tree; licensing and third-party credits are preserved.
Validation
e233414: the actual selector exceeds its 1-second controlled VM deadline and public validation exceeds its 5-second deadline for node width1e30plus edge width1e25.e233414.Exact-head CI41131222445 passes: 16 successful jobs and 4 normal skips (full-regression, website and two deployments). Both browser shards, Windows portability22/24, maintained Node compatibility, three-platform package smoke, generated/ZIP checks and selected regressions actually passed. The skipped broad lane is not claimed as executed.
Test-value assessment: node-width-only inputs missed the independent edge-width clearance failure. The existing public-CLI test now covers it, while the focused selector control protects available ports without freezing automatic coordinates. The same blocker calculation owns candidate rejection and interval advancement; no dimension cap, new router or public API was added. Evidence uses fixed JSON and controlled selector comparisons, not a new Agent-generation benchmark.
Contributor review
The contributor has explicitly confirmed personal review of
7e8ce82376ea56d7074676b3d30aafd78264fff4and can answer questions about this correction. The earlier confirmation ofe233414remains recorded for that revision.Current integration · 31 October
Head
26ae5382fc1726444cbf5e4219478435bf36fcbcincludes maintainer #1173 and dev63c9263e84bd3993cab8e09b3d69888857858635. The original correction and test blobs remain byte-identical to7e8ce82376ea56d7074676b3d30aafd78264fff4; the existing personal confirmation retains that scope. The combined ZIP was regenerated and checked against the complete Skill tree.Local qualification on tree
e1db74350fb078e2a80cf9149a700d29ed9d46db: generated/golden checks,19 core smoke cases,26 focused Sequence cases including Chrome, this PR's focused regression and clean-package smoke. The later integration of #1174 changes only the README GIF and receipt: the unchanged README/Gallery tests pass15 cases with one native Windows-only local skip on final tree82164e0e73dc24ff2850819d235299b033b5b145. All three input-artifact hashes match the separately recaptured #1174 animation. Source, tests and ZIP are unchanged by that second step. The earlier README freshness failures remain visible in the previous CI runs.CI41175232686 passed on this exact public head: 17 successful jobs, 3 expected skips, no failures. The complete regression lane was skipped by the existing scope policy; it is not counted as executed. Windows path-test steps: (Node 22) skipped; (Node 24) skipped; skipped steps are not counted as native test execution. Deployment jobs were skipped. The separate generated-media PR1174 remains Draft pending its own personal review; this update does not claim a new personal review of these mechanical commits.
BlueboxC