Conversation
TEMP: pin Terminal.Gui to 2.5.0-tig-remove-cm-followup.1, a preview built from tui-cs/Terminal.Gui#5416 (ConfigurationManager removal), restored from a vendored local_packages feed via nuget.config. Part of the v2.5.0 ecosystem-validation gate (tui-cs/Terminal.Gui#5630). No code changes were required: Terminal.Gui.Cli does not use ConfigurationManager, virtual View.Text, or IAcceptTarget, and builds warning-free against 2.5.0. Follow-up: swap to the public 2.5.x package on nuget.org and drop the vendored feed. Pattern precedent: tig/winprint#272. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BVbLXNzbus2MTXmiJDBErL
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aa093581f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <!-- TEMP: Terminal.Gui 2.5.0 preview built from tui-cs/Terminal.Gui#5416, restored | ||
| from the vendored ./local_packages feed (see nuget.config). Switch back to a | ||
| public nuget.org version once 2.5.x ships. --> | ||
| <TerminalGuiVersion Condition="'$(TerminalGuiVersion)' == ''">2.5.0-tig-remove-cm-followup.1</TerminalGuiVersion> |
There was a problem hiding this comment.
Avoid publishing a dependency that only exists locally
On every push to develop, the existing .github/workflows/release.yml packs Terminal.Gui.Cli and pushes it to NuGet.org, so its generated nuspec will expose this Terminal.Gui version as a dependency. The only copy of that custom prerelease is the repository-local feed, and neither nuget.config nor local_packages/ is available to package consumers; therefore installing each newly published development build from NuGet.org will fail to resolve this dependency. Suppress publishing while this pin is active or publish the preview dependency to a feed that consumers can access.
Useful? React with 👍 / 👎.
…ba423 The .1 package was built from a stale #5416 commit (93c3b3d4) that predated real config-load defect fixes landed later on the branch. followup.2 is built from the 5416 branch head (e8aba423). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BVbLXNzbus2MTXmiJDBErL
Drop the vendored 5416 preview feed (local_packages/, nuget.config, .gitignore exceptions) and restore Terminal.Gui 2.5.0-develop.55 from nuget.org. Same pattern as tui-cs/Editor#287. Swap to stable 2.5.x before merge. Co-authored-by: Tig <tig@users.noreply.github.com>
|
I retargeted this PR from the vendored 5416 preview pin to public nuget.org DO NOT MERGE with the pre-release pin in placeThis PR pins Terminal.Gui to public nuget.org 2.5.0-develop.55 (
What this isPart of the Terminal.Gui v2.5.0 ecosystem-validation gate (tui-cs/Terminal.Gui#5630). tui-cs/Terminal.Gui#5416 and tui-cs/Terminal.Gui#5656 are on Pattern: tui-cs/Editor#287. API breaksNone required so far.
Build and test results will be updated after restore against nuget.org Follow-up
Refs: tui-cs/Terminal.Gui#5416, tui-cs/Terminal.Gui#5630, tui-cs/Terminal.Gui#5656. |
Public Terminal.Gui 2.5.0-develop.55 emits indexed SGR (e.g. ESC[96m / ESC[40m) instead of the truecolor RGB sequences from the vendored 5416 preview. Glyphs and layout are unchanged; only the color encoding shifted. Regenerated help.ans and help-browser.ans via UPDATE_SNAPSHOTS. Co-authored-by: Tig <tig@users.noreply.github.com>
|
Build and tests are green on DO NOT MERGE with the pre-release pin in placeThis PR pins Terminal.Gui to public nuget.org 2.5.0-develop.55 (
What this isPart of the Terminal.Gui v2.5.0 ecosystem-validation gate (tui-cs/Terminal.Gui#5630). tui-cs/Terminal.Gui#5416 and tui-cs/Terminal.Gui#5656 are on Pattern: tui-cs/Editor#287. API breaksNo library API changes. The only 2.5.0-develop.55 break I hit was ANSI color encoding in the help goldens. Public Test results
Restore sources were nuget.org only. Debug build: 0 warnings, 0 errors. Follow-up
Refs: tui-cs/Terminal.Gui#5416, tui-cs/Terminal.Gui#5630, tui-cs/Terminal.Gui#5656. |
This reverts commit d82e4fc.
|
I reverted the help ANSI golden regeneration. The pin-only commit ( macOS CI failed on the regenerated goldens, which matches that. Head is now a revert back to those original snapshots. Do not merge until the pin is stable 2.5.x. I still cannot rewrite the PR description (not agent-managed). Please replace it with the DO NOT MERGE body from the earlier comment. |
|
HEAD CI is green on ubuntu, macOS, and Windows (https://github.com/tui-cs/cli/actions/runs/33757609533). Restore is nuget.org I still cannot edit this description (not agent-managed; GitHub 403). Same as tui-cs/Editor#287, please paste the text below over the current body so it no longer talks about the vendored 5416 preview. DO NOT MERGE with the pre-release pin in placeThis PR pins Terminal.Gui to public nuget.org 2.5.0-develop.55 (
What this isPart of the Terminal.Gui v2.5.0 ecosystem-validation gate (tui-cs/Terminal.Gui#5630). tui-cs/Terminal.Gui#5416 and tui-cs/Terminal.Gui#5656 are on Pattern: tui-cs/Editor#287. API breaksNo library API changes. No golden update is required. The existing truecolor help snapshots passed on ubuntu, macOS, and Windows. Test results
Follow-up
Refs: tui-cs/Terminal.Gui#5416, tui-cs/Terminal.Gui#5630, tui-cs/Terminal.Gui#5656. |
Drop the 2.5.0-develop.55 pin. Restore stays on nuget.org. No vendored feed. Co-authored-by: Tig <tig@users.noreply.github.com>
|
I bumped the pin to public nuget.org 2.5.0-beta.1. Title is updated. I cannot rewrite the description (not agent-managed; GitHub 403). Please replace the body with the text below and drop the DO NOT MERGE warning. This PR pins This is the v2.5.0 ecosystem-validation bump for No library API changes. Pattern: tui-cs/Editor#287. Refs: tui-cs/Terminal.Gui#5416, tui-cs/Terminal.Gui#5630, tui-cs/Terminal.Gui#5656. |
This PR pins public
Terminal.Gui 2.5.0-develop.55from nuget.org soTerminal.Gui.Clican be validated ahead of the v2.5.0 tag. Before merging, once stable 2.5.x is on nuget.org:TerminalGuiVersioninDirectory.Build.propsto the public stable 2.5.x versionDo not vendor a local nupkg. The 5416 preview feed (
local_packages/,tgui-pr-5416nuget.config source,.gitignorenupkg exception) is already gone.Summary
Retargets this PR from the vendored
2.5.0-tig-remove-cm-followup.2pin to public2.5.0-develop.55as part of tui-cs/Terminal.Gui#5630 Workstream 4.No 2.5.0 API breaks in
Terminal.Gui.Cli(ConfigurationManager,View.Text,IAcceptTargetunused).Help ANSI goldens were regenerated against indexed SGR from
2.5.0-develop.55, then reverted. CI is green without that snapshot change.Validation
CI on this head: build-and-test ubuntu/macos/windows green.
Refs: tui-cs/Terminal.Gui#5416, tui-cs/Terminal.Gui#5630, tui-cs/Editor#287.