Repository navigation
Make formatting check enforceable - #15
Merged
Merged
Conversation
The previous raco fmt --check invocation was unsupported and always exited 1 while continue-on-error hid the failure. Format each Racket file in the CI checkout with the catalog fmt, then require a clean diff so the check is portable and actually enforced. The whole tree is now normalized against fmt @ 4e1ed68e so the enforced check passes. Verified locally on Racket 9.2 CS: all 50 files compile, the agent-contract and API test files pass, and a re-run of raco fmt -i produces no further diff.
turinglambdaai
force-pushed
the
fix/format-check
branch
from
September 30, 2026 03:12
9ea35ab to
81bf489
Compare
Owner
Author
|
Rebuilt on current main (b22fc03): the enforced check needs a canonical tree, so this normalizes all 50 .rkt files against catalog fmt (@ 4e1ed68e) and then requires a clean diff in CI. Verified locally on Racket 9.2 CS — full tree compiles, agent-contract and API tests pass, and a second fmt pass is a no-op. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing raco fmt --check invocation is unsupported and always exits 1, while continue-on-error hides it. Format each Racket file in the CI checkout, then require a clean diff so the check is portable and actually enforced. The current tree was validated locally and produces no formatting diff.