Repository navigation
feat(proxy): label webhook and form calls on the existing audit log - #85
Merged
Merged
Conversation
Inbound trigger URLs were forwarded as surface=transparent, so they were indistinguishable from other ungated traffic. Classify n8n's webhook/form/waiting/mcp-trigger prefixes as surface=trigger with the same logger and --log-identity IAP fallback already used elsewhere. Co-authored-by: Cursor <cursoragent@cursor.com>
n8n's default MCP test endpoint is a sibling of /mcp, not a child, so it was still logged as transparent. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/webhook,/form, waiting,/mcp,-testvariants) assurface=trigger/operation=invokeon the existing proxy audit logger (logger: n8n-cli-proxy), not a separate stream.--log-identitystack as REST/MCP: IAPX-Goog-Authenticated-User-Emailwhen no verified middleware identity exists. Trigger paths still do not run server middleware (public webhooks stay ungated).transparent.Test plan
bun test tests/proxy/trigger-path.test.ts tests/proxy/logging.test.ts tests/proxy/proxy.logging.test.tsmake quality-gate(1968 tests)/webhook/...log line hassurface=triggerand, with--log-identityplus IAP in front,identitySource=iap-header/mcp-server/stayssurface=mcpwhen the gate is on, and is not swallowed by/mcpMade with Cursor