Skip to content

fix: add missing apiroute monitoring path annotation #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreddedbacon merged 1 commit into from
Oct 27, 2026
Merged

fix: add missing apiroute monitoring path annotation #529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/lagoon/routes.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,11 @@ func handleAPIRoute(defaultIngressClass string, apiRoute RouteV2) (RouteV2, erro
} else {
routeAdd.IngressClass = defaultIngressClass
}
if apiRoute.MonitoringPath != "" {
routeAdd.MonitoringPath = apiRoute.MonitoringPath
} else {
routeAdd.MonitoringPath = defaultMonitoringPath
}

// if the route comes through as an active or standby route from the api
// handle setting the migrate flag on the route
Expand Down
1 change: 1 addition & 0 deletions internal/testdata/node/ingress-templates/active-standby-api-routes/active.example.com.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ metadata:
lagoon.sh/branch: prod-left
lagoon.sh/version: v2.7.x
monitor.stakater.com/enabled: "false"
monitor.stakater.com/overridePath: /
nginx.ingress.kubernetes.io/ssl-redirect: "true"
labels:
activestandby.lagoon.sh/migrate: "true"
Expand Down
1 change: 1 addition & 0 deletions internal/testdata/node/ingress-templates/active-standby-api-routes/other.example.com.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ metadata:
lagoon.sh/branch: prod-left
lagoon.sh/version: v2.7.x
monitor.stakater.com/enabled: "false"
monitor.stakater.com/overridePath: /
nginx.ingress.kubernetes.io/ssl-redirect: "true"
labels:
activestandby.lagoon.sh/migrate: "false"
Expand Down
1 change: 1 addition & 0 deletions internal/testdata/node/ingress-templates/active-standby-api-routes/test.example.com.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ metadata:
lagoon.sh/branch: prod-left
lagoon.sh/version: v2.7.x
monitor.stakater.com/enabled: "true"
monitor.stakater.com/overridePath: /
nginx.ingress.kubernetes.io/ssl-redirect: "true"
uptimerobot.monitor.stakater.com/alert-contacts: alertcontact
uptimerobot.monitor.stakater.com/interval: "60"
Expand Down
1 change: 1 addition & 0 deletions ...a/node/ingress-templates/api-defined-routes-with-lagoon-yml-fastly/other.example.com.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ metadata:
lagoon.sh/branch: main
lagoon.sh/version: v2.7.x
monitor.stakater.com/enabled: "false"
monitor.stakater.com/overridePath: /
nginx.ingress.kubernetes.io/ssl-redirect: "true"
labels:
activestandby.lagoon.sh/migrate: "false"
Expand Down
1 change: 1 addition & 0 deletions ...ta/node/ingress-templates/api-defined-routes-with-lagoon-yml-fastly/test.example.com.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ metadata:
lagoon.sh/branch: main
lagoon.sh/version: v2.7.x
monitor.stakater.com/enabled: "true"
monitor.stakater.com/overridePath: /
nginx.ingress.kubernetes.io/ssl-redirect: "true"
uptimerobot.monitor.stakater.com/alert-contacts: alertcontact
uptimerobot.monitor.stakater.com/interval: "60"
Expand Down
1 change: 1 addition & 0 deletions ...testdata/node/ingress-templates/api-defined-routes-with-lagoon-yml/other.example.com.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ metadata:
lagoon.sh/branch: main
lagoon.sh/version: v2.7.x
monitor.stakater.com/enabled: "false"
monitor.stakater.com/overridePath: /
nginx.ingress.kubernetes.io/ssl-redirect: "true"
labels:
activestandby.lagoon.sh/migrate: "false"
Expand Down
1 change: 1 addition & 0 deletions .../testdata/node/ingress-templates/api-defined-routes-with-lagoon-yml/test.example.com.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ metadata:
lagoon.sh/branch: main
lagoon.sh/version: v2.7.x
monitor.stakater.com/enabled: "true"
monitor.stakater.com/overridePath: /
nginx.ingress.kubernetes.io/ssl-redirect: "true"
uptimerobot.monitor.stakater.com/alert-contacts: alertcontact
uptimerobot.monitor.stakater.com/interval: "60"
Expand Down
Loading