fix: attempting to interrupt program in api-db/keycloak-db kills bash - #4171
Open
rocketeerbkw wants to merge 1 commit into
Open
rocketeerbkw wants to merge 1 commit into
rocketeerbkw wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General Checklist
Database Migrations
n/a
Description
When bash is configured with
errexit, it kills the session even when you are trying to quit a program which is very annoying.make api-developmentdco -p lagoon exec api-db bashless /etc/mysql/my.cnflessThis happens because the
set -eo pipefailin an entrypoint is sourced in.bashrcwhich setserrexitfor the entire session.Other entrypoints can
set -ebut they are executed instead of sourced, so they don't pollute the bash session.Closing issues
n/a