Improve API Request Validations - #194
Open
betsyecastro wants to merge 10 commits into
Open
Conversation
betsyecastro
added
🐛 bug
betsyecastro
changed the title
betsyecastro
marked this pull request as draft
May 20, 2025 16:55
betsyecastro
marked this pull request as ready for review
June 5, 2025 18:51
shukla-m
self-requested a review
June 9, 2025 20:23
|
@betsyecastro I added myself as a reviewer on this PR, as we discussed last week, and pulled in the code to test locally. I tried the following URL which passes validation for the
This might not be an issue but wanted to mention, in case |
…built in validation rules for search fields
- use more thorough search pattern regex (for example, some profile slugs may have dashes and quotes) - add `search_section` and `accepting_undergrad` as valid params - simplify the `with_data` validation by using the built-in `Rule::prohibitedIf()` - also allow `with_data` if `data_type` is filled - for extra param checking, use the `after()` method instead of `passedValidation()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the following API request validation rules: