Repository navigation
Conversation
Signed-off-by: Edward Liang <edward.liang@improving.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a two-part Haystack + Valkey cookbook with a deterministic Python sample. The walkthroughs cover
ValkeyDocumentStore, vector retrieval, metadata filters, and a RAG pipeline with optional model-backed embedding and generation paths.Issue
N/A. This follows the cookbook acceptance criteria in PR #40.
Changes
README.mdand cookbook index files: add navigation for the new Haystack integration.cookbooks/framework-integrations/haystack/: add getting-started and RAG walkthroughs with prerequisites, security guidance, configuration references, teardown steps, and navigation.cookbooks/framework-integrations/haystack/sample/: add a runnable deterministic sample using fixed four-dimensional embeddings, Haystack's document store and retriever APIs, metadata filtering, environment overrides, and cleanup tests.sample/requirements.txt: pinvalkey-glideandvalkey-glide-syncto2.5.0, alongside the Haystack integration and test dependencies.haystack/README.md: disclose that Haystack is maintained by deepset..github/workflows/cookbook-python.yml: add temporary Python lint and integration-test coverage for Haystack against Valkey Bundle8.1.4and9.1.1, with SHA-pinned actions.Tests
VALKEY_PORT=6381 .venv/bin/python -m pytest -qagainst Valkey Bundle8.1.4: 4 passed.VALKEY_PORT=6382 .venv/bin/python -m pytest -qagainst Valkey Bundle9.1.1: 4 passed.ruff==0.11.13, Python compileall, scoped Markdownlint, Actionlint, Lychee, andgit diff --cached --checkpassed.Blockers / Future work